[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [pdt-dev] Bug 445275 - Migrate from org.eclipse.dltk.internal.core.SourceRange to api version

Ok, I think I tested my patch with most popular plugins. I wasn't able to remove deprecated SourceRange completely so if someone will have idea how to do it better than I did it let me know:)

https://git.eclipse.org/r/#/c/36859/

Thanks,
Michal

On Thu, Dec 11, 2014 at 3:39 PM, Dawid PakuÅa <zulus@xxxxxxxxx> wrote:
Hi,

Iâm always checking:
Doctrine/Symfony/Composer/Twig plugins
MakeGood

Sometimes also Phing and SmartyPDTÂ

--
Dawid PakuÅaÂ

On 11 Dec 2014 at 15:20:47, MichaÅ NiewrzaÅ (michal.n@xxxxxxxx) wrote:

Hi Dawid,

Sometime ago I created a patch for deprecated SourceRange class, but I didn't have time to check it with 3rd party plugins to be sure they are compatible. Today I checked:

Symfony plugins are using part of API fromÂAbstractCompletionStrategy so I reorganized patch to not break anything. What other plugins you are checking in such cases?


Thanks,
MichaÅ