[pdt-dev] RE: [Dltk-dev] Re: index2

["Roy Ganor" <roy@xxxxxxxx>]

Hi Alex,

Problem is that until h2 is included in orbit, PDT users need to create a plugin manually that includes the h2 library and then load it somehow. I think it is too complicated...

Any chance to make this plugin internal to core or as Michael created initially as an external one?

 

Thank you for your time,

Roy

From: alex@xxxxxxxxx [mailto:alex@xxxxxxxxx]
Sent: Tuesday, August 11, 2009 5:55 PM
To: Roy Ganor
Cc: DLTK Developer Discussions; pdt-dev@xxxxxxxxxxx
Subject: Re: [Dltk-dev] Re: index2

 

Hi Roy,

I think we should not include (optional) external dependencies into DLTK builds.
Users can download h2 from the link below until it is included in Orbit.

What do you think?

And DLTK includes org.eclipse.dltk.index.sql.* plugins actually using h2.

Regards,
Alex

----- Original Message -----
From: "Roy Ganor" <roy@xxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>, "Alex Panchenko" <alex@xxxxxxxxx>, pdt-dev@xxxxxxxxxxx
Sent: Tuesday, August 11, 2009 9:36:57 PM GMT +06:00 Almaty, Novosibirsk
Subject: RE: [Dltk-dev] Re: index2

Hi Alex,

Eclipse PDT was built against the latest integration DLTK build already, thanks for providing this build. I’ll be able to make the adjustments later on this week.

Can you explain why org.h2.core was not included in the core DLTK package?

 

Best Regards,

Roy

 

Btw - Michael - thanks for forwarding, have fun J

From: dltk-dev-bounces@xxxxxxxxxxx [mailto:dltk-dev-bounces@xxxxxxxxxxx] On Behalf Of Michael Spector
Sent: Tuesday, August 11, 2009 4:56 PM
To: Alex Panchenko; DLTK Developer Discussions; pdt-dev@xxxxxxxxxxx
Subject: [Dltk-dev] Re: index2

 

Hi Alex,

 

I'm forwarding this mail to DLTK/PDT mailing lists, since I'm unable to check this (I'm on holiday).

 

Thanks,

Michael

On Sat, Aug 8, 2009 at 12:23 AM, Alex Panchenko <alex@xxxxxxxxx> wrote:

Hi Michael,

1) I have built h2.jar by their own build script, it is available at
http://www.eclipse.org/downloads/download.php?file=/technology/dltk/externals/h2-1.1.116.jar

It should not be downloaded as part of DLTK plugins, since it's external dependency and users should download it explicitly.

2) I have made code adjustments, so Ruby & TCL work as before even if new plugins are available.
(However, I believe we need additional checks & testing in this area).
Please make adjustments to your extensions (contribute indexer2 and disable other indexers only for your nature) and check if it works for you.

If you have any questions - let's discuss them.

When everything is fine for you & us - I'll make new build and upload it to eclipse.
I really don't want to make buggy builds publicly available.

Thank you,
Alex