[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdt-dev] Question about debug.daemon plugin.
- From: Dave Kelsey <d_kelsey@xxxxxxxxxx>
- Date: Tue, 6 Jan 2009 16:36:52 +0000
- Delivered-to: email@example.com
Thanks for the response Michael, I will
make the change, test it and commit it.
pdt-dev-bounces@xxxxxxxxxxx wrote on 06/01/2009 13:37:45:
> The only reason for that IIRC was eliminating the need to load the
> stuff (debug plug-in has a dependency with PHP core) on startup. I
> don't understand why it's being done in PHPDebugPlugin instead of
> DaemonPlugin, I think the listeners startup code can be moved there.
> 2009/1/6 Dave Kelsey <d_kelsey@xxxxxxxxxx>:
> > I noticed a problem where the debug socket listeners were not
> > in some cases when PDT was first started. It turns out that if
> > have a PHP file open or the PHP Debug perspective being listed
as an opened
> > perspective (not necessarily the active perspective) then the
> > listeners are not started.
> > Looking at the code I see that the debug.daemon (which contains
the code to
> > start the socket listeners) plugin registers an earlyStartup,
> > starting of that plugin (earlyStartup() or start() ) actually
> > anything, so the earlyStartup is redundent. The code to start
> > is actually found in the debug.core plugin in its start() method,
> > means that unless this plugin gets loaded the socket listeners
> > until it does get loaded and this can and does get delay loaded.
> > The obvious answer to this would be that as the debug.daemon
> > earlyStartup registered, that this should start the socket listeners,
> > the debug.core plugin and I would like to make this change. Does
> > why the code did it this way or is there any good reason why
it shouldn't be
> > changed ? (An alternative would be to have the debug.core plugin
> > earlyStartup and remove the one from the debug.daemon plugin).
> > I would like to get this change into PDT 2.0.1 as well.
> > Cheers
> > Dave Kelsey
> > ________________________________
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
> > _______________________________________________
> > pdt-dev mailing list
> > pdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/pdt-dev
> pdt-dev mailing list
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6