[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] newbie committer question

The only other general piece of advice I would give is to be sensitive to the rhythms of the build and release cycle. On a weekly basis, integration builds are every Tuesday morning. This means releasing changes on Monday night there is no chance to verify in a nightly build before contributing to a real build. A good time to release larger changes is around Wednesday after the weekly build is out of the way. In a similar vein, releasing big changes right before milestone week is risky, but right after a milestone ideal. During milestone week itself we try to keep changes down to a minimum - mostly major bug fixes or polish items that would be embarrassing to appear in a milestone build. At that time we're mainly focused on producing solid builds, and will often accept leaving a bug in the code rather than risking destabilizing the milestone (depending on the nature of the bug, the complexity of the fix, and how close we are to Friday).

During the release candidates we progressively increase testing and lock down on changes according to the end-game plan [1]. If you ever want a second a opinion on timing for releasing a change, just ask. Also if you just want another set of eyes on a change in code you aren't familiar with, you can always ask someone else for a review (I usually look at the revision history of a file to see the best person to ask when I want a second opinion). As a committer you don't need any review for releasing changes, but we still frequently do reviews between committers when someone isn't completely comfortable with a change they are making. Alot of this is common sense that you probably already know as a Buckminster committer, but thought it worth mentioning.

[1] http://www.eclipse.org/eclipse/development/freeze_plan_3.5.php

Henrik Lindberg <henrik.lindberg@xxxxxxxxxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

04/14/2009 10:20 AM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

P2 developer discussions <p2-dev@xxxxxxxxxxx>
[p2-dev] newbie committer question

As a new committer (woo hoo !!) I just made the first p2 commit (a  
very small bugfix https://bugs.eclipse.org/bugs/show_bug.cgi?id=272142).
Are there more things I should do after having committed something to  
HEAD? (I know about iplog and IP issues when handling patches).

Henrik Lindberg

p2-dev mailing list