Re: [orion-dev] Proposals for enhancement to ContentAssist

[Ken Walker <Ken_Walker@xxxxxxxxxx>]

John and I will be at EclipseCon with Szymon and Gosia so we'd like to get together and talk about the ideas you have for Content assist or any other areas of Orion which you might be consuming.

_javascript_ tooling will be a focal point post 1.0 and as part of that, the content assist framework.

There's a BOF scheduled for next Tuesday (wow, next week so soon!) - http://www.eclipsecon.org/europe2012/eclipse-orion-explore-possibilities

Cheers,

Ken Walker
Co-Lead Eclipse Orion Project | Tools for the Web, On the Web
http://orionhub.org | http://wiki.eclipse.org/Orion



Tom Schindl ---2012/10/16 02:34:20 AM---Hi, Looked at it and your initial idea is exactly what I implemented in the

From:	Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>
To:	orion-dev@xxxxxxxxxxx,
Date:	2012/10/16 02:34 AM
Subject:	Re: [orion-dev] Proposals for enhancement to ContentAssist
Sent by:	orion-dev-bounces@xxxxxxxxxxx

---

Hi,

Looked at it and your initial idea is exactly what I implemented in the
referenced commit.

I haven't thought about the security stuff and so I'll rethink my
current way a bit. In Java i already have an attributed string and so it
might be better to push such an attributed string into the _javascript_
world so one would pass an object like this to the content assist:

{
  "styleClass" : "public-method",
  "segments" : [
     { "value" : "bla() : void" },
     { "value" : " - Test",
          "style" : {
             "bold" : "false",
             "italic" : "false",
             "color" : "AAA"
          }
     }
  ]
}

I'll try to implement this today and create a bugzilla.

Tom

Am 16.10.12 04:58, schrieb Andrew Eisenberg:
> Hi Tom,
> 
> I'd like to see icons and better styling available in content assist
> proposals.  This would make things look significantly more professional
> as your screenshot shows.  See this bug for some recent discussions in
> this area:
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=389212
> 
> I had toyed around doing something similar to what you suggested.  But
> in the end, I implemented a small, fixed number of styles that are
> pre-determined by orion and clients can choose from.  It is a
> preliminary solution and something more sophisticated needs to be
> implemented, but it solved my original purpose.
> 
> Sanitizing the html for the proposal before displaying it would be one
> way to open up the styling, but keep things secure.
> 
> On Mon, Oct 15, 2012 at 3:59 PM, John Arthorne <John_Arthorne@xxxxxxxxxx
> <mailto:John_Arthorne@xxxxxxxxxx>> wrote:
> 
>     Hi Tom,
> 
>     Thanks for introducing yourself here for those you might not know
>     you. Consuming the Orion editor without the server is quite a common
>     case and one I think we support fairly well.
> 
>     Both of your content assist suggestions are very reasonable
>     requests, and I think we can easily add them immediately after 1.0
>     is out. We can cherry-pick a change from GitHub but we still need a
>     bug report to track. For a) we would need to do some sanity check of
>     the HTML to ensure it is not inserting malicous HTML or scripts. We
>     actually had code much like this early on, but we restricted it
>     because of security concerns. However we could open this up to
>     accept img and formatting tags at least to allow it to be made
>     prettier. Please enter bug reports for both of these enhancements
>     and include a pointer to the commit on github. Contributions are
>     most welcome!
> 
>     John
> 
> 
> 
>     *Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx
>     <mailto:tom.schindl@xxxxxxxxxxxxxxx>>*
>     Sent by: orion-dev-bounces@xxxxxxxxxxx
>     <mailto:orion-dev-bounces@xxxxxxxxxxx>
> 
>     10/15/2012 03:28 PM
> 
>     Please respond to
>     Orion developer discussions <orion-dev@xxxxxxxxxxx
>     <mailto:orion-dev@xxxxxxxxxxx>>
> 
> 
>     		 
>     To
>     		 orion-dev@xxxxxxxxxxx <mailto:orion-dev@xxxxxxxxxxx>
>     cc
>     		 
>     Subject
>     		 [orion-dev] Proposals for enhancement to ContentAssist
> 
> 
>     		 
> 
> 
> 
> 
> 
>     Hi,
> 
>     Before filing bugs against Orion I'd like to introduce myself and give
>     some background informations on what I'm doing with Orions-Editor.
> 
>     I'm currently working on a proof of concept Desktop-(Java)-IDE using
>     JavaFX as the widget toolkit because JavaFX does not yet have a rich
>     text widget I'm simply embedding Orions editor component through the so
>     called WebView and use the _javascript_ <=> Java bridge provided by JavaFX
>     => I don't have an orion-server! [1,2]
> 
>     Now to my request I have 2 problems with the current content assist:
>     a) the proposals are not nice enough (compare them to the proposals
>       provided by the Eclipse-IDE). I'd like to show an icon in front and
>       meta informations like the package, owning class, ... in more light
>       color
> 
>     b) I need not only insert informations after the prefix but replace the
>       prefix instead.
>       There are various reasons:
>       * FQN class names need to be inserted (see attached screenshot)
>       * Upper/lower case replacement e.g. imagine in write sett and popup
>         the content assist which proposes setText()
> 
>     I've forked the client stuff to my github repo and implemented both
>     functions. [3,4,5]
> 
>     Is this something you want to integrate into your codebase after you
>     have shipped your release? How is your process? Are you using gerrit or
>     accept pull request on github. I'm committer on various eclipse projects
>     if that matters.
> 
>     Next thing I'll have to take a look is to automatically add imports on
>     content proposals but those 2 feature are the most important.
> 
>     Tom
> 
>     [1]https://github.com/tomsontom/fx-ide
>     [2]http://tomsondev.bestsolution.at/2012/10/04/eclipse-techs-on-steroids/
>     [3]https://github.com/tomsontom/orion.client/commits/master/
>     [4]https://github.com/tomsontom/orion.client/commit/368ecc215c159aa5513cd89adcdb9331bd74086e
>     [5]https://github.com/tomsontom/orion.client/commit/35ad2c842332a03fedd2658fd43a0e59347ed054
> 
>     -- 
>     B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
>     ------------------------------------------------------------------------
>     tom schindl                 geschäftsführer/CEO
>     ------------------------------------------------------------------------
>     eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512
>     935833 <tel:%2B%2B43%20512%20935833>
>     http://www.BestSolution.at <http://www.bestsolution.at/>
>                          phone    ++43 512 935834
>     <tel:%2B%2B43%20512%20935834>
>     _______________________________________________
>     orion-dev mailing list
>     orion-dev@xxxxxxxxxxx <mailto:orion-dev@xxxxxxxxxxx>
>     https://dev.eclipse.org/mailman/listinfo/orion-dev
> 
> 
>     _______________________________________________
>     orion-dev mailing list
>     orion-dev@xxxxxxxxxxx <mailto:orion-dev@xxxxxxxxxxx>
>     https://dev.eclipse.org/mailman/listinfo/orion-dev
> 
> 
> 
> 
> _______________________________________________
> orion-dev mailing list
> orion-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/orion-dev
> 


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                 geschäftsführer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
http://www.BestSolution.at                      phone    ++43 512 935834
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev