Re: [orion-dev] git-status.html UI

[Libing Wang <Libing_Wang@xxxxxxxxxx>]

Hi, John:
Thanks a lot for the comments.
Especially for your comment 3, currently we are disabling the commit message area if there is nothing in the staged area. Your "speed up" suggestion makes good sense for the work flow.
But I have a question for the second half of the comment: when you mentioned "listing the to-be-staged files in the Staged area grayed out as soon as the user submits.", did you mean to gray out the files in the Unstaged area? To me, as you are staging files from the unstaged area, so it will be better to gray them out in the same area while server is processing the request. But please correct me if I misunderstand that .

--Libing


Tomasz Zarna ---08/23/2011 04:36:39 AM---Thanks for the comment John. It makes total sense to me. Could you please file a bug for each bullet

From: Tomasz Zarna <TomaszZarna@xxxxxxxxxx>
To: Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date: 08/23/2011 04:36 AM
Subject: Re: [orion-dev] git-status.html UI
Sent by: orion-dev-bounces@xxxxxxxxxxx

---

Thanks for the comment John. It makes total sense to me. Could you please
file a bug for each bullet and CC Libing and me?
--
Tomek



From:		 John J Barton <johnjbarton@xxxxxxxxxxxxxxx>
To:		 Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date:		 2011-08-20 20:39
Subject:		 [orion-dev] git-status.html UI
Sent by:		 orion-dev-bounces@xxxxxxxxxxx



A couple of suggestions after using the git-status.html UI for a few days.

1. The command icons for each file are on the far right hand side; they
only appear when you hover on the file line. But there is no visual
indication of where the lines are and it's very tedious to carefully move
way across the line to get to the icons. Icons on the left side of the name
could be flush against the name; alternating line highlights would also
help.

2. The black lines delimiting the areas on the UI are unclear. We have:
Unstaged
-----------------------------------
<a file>

Staged
----------------------------------
Commit Message
+------
|
+------

So the file looks it could belong to "Staged" when it is Unstaged.  I think
it would be clearer with zero or one line:
Unstaged
<files> or "(none)"
Staged
<files> or "(none)")
Commit message
...

3. Overall this UI is slower than command line (not counting user errors,
which usually favors GUI). One improvement that would help a lot would be
to enable the Commit message field as soon as the user submits a request
for staging. I don't think the staging can fail in normal circumstances, so
at worst the user enters some text that may be lost in a rare server fail
or commit collision case. While the staging request is serviced, the user
is typing. This overlap would dramatically speed up commits. The "Commit"
button could be disabled until the staging completes.

An improvement would include listing the to-be-staged files in the Staged
area grayed out as soon as the user submits. That way the Commit box does
not move when the Staging completes.

jjb
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev


_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev