Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orbit-dev] Continue to require ATO CQs?

Find some documentation on how to use Gerrit for code review here

If you want more details you may read


On Fri, Apr 17, 2020 at 9:52 PM Sina Madani <sinadoom@xxxxxxxxxxxxxx> wrote:

Hi Roland,


Sorry about that. I have never used Gerrit before and I didn’t encounter any instructions on the Orbit website / FAQ / resources etc. regarding Gerrit, how to clone using Gerrit etc. What should I have done instead? If using Git (as we do with other projects – at least in the project I’m involved in, we don’t use Gerrit at all) isn’t the right way then it would be helpful to add some instructions to the relevant sources, unless Gerrit is common knowledge amongst all Eclipse committers and I’m the odd one out.





From: Roland Grunberg
Sent: 17 April 2020 20:41
To: Orbit Developer discussion
Cc: Sina Madani
Subject: Re: [orbit-dev] Continue to require ATO CQs?


Alright, so we'll leave 3.2 for now. I can see that 3.5.2 along with some

of its dependencies have been added. In the future I would just be sure

to use the gerrit clone url so that your changes get pushed up for review.

Even if you plan to self-approve them the changes get verified by : which can be useful.


I think the only thing missing is that the bundles need to be added

to releng/aggregationfeature/feature.xml or they won't be added to

the build itself.



orbit-dev mailing list
To unsubscribe from this list, visit

Back to the top