Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orbit-dev] switch from com.spotify.docker.client to org.mandas.docker.client
  • From: "Homer, Tony" <tony.homer@xxxxxxxxx>
  • Date: Thu, 16 Jan 2020 22:44:34 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcnhoV3tCwNbPMiR0iUNrvWCQbScffFk4u2J7N0LeIQ=; b=GvxtyG+eTkDJGjfOZ5io0+THn/CIusOyqcwWhHcPODgYRna6d0YMd+vQ94Brmwkk7mRxZQHxCqpRPJJNGXFE0nn0zwecJv3o798sX25nU+sdq/MgUS5zA65bKsOXk7cbTHgDTpfT8kwC0F46SWEhlGw2dX1zBWCA27g90evg66N3D3PBre+nwt8bIRHxbK0HRi1QunrHYcOkn6LH64Y81+JdpxywgGf5Z3xEHerUEduiVsHtlB/nJ+4E64pUnqjZ+o91xBLm6jJrzaz/m2Pt2pN5YLvr7MeMaBHBQNigyczYUrZwVBlpjqZx0OaFQHwBMyHyQeB4xA9TilS5Zoo5JA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UX4jXa9BbSfwiF9Oc//4dqCzMCMi5rBKWSBigdg/HuSNa+aeiddEey/cEqvh12Glaab3/reXpJOpzgaVXFLrAOiHLis6IR0tMypAqGcSgvrj/hz7PXfCe4I68K9U5fhJne0vkhItGBHtRb4kGTqE8YvdecENhv9g/bOoG8+Dcgf04r4M34U804aatdnS28dWDT3D3Ndci5riJzOS4bG+G6SVsuSc9m4ZmOFmiINCQLFMl/0JAmVAWOoMkiSs+wxMRL/pDQERKMs8o/Hp3LM6lDDU1PYi7TaQrwxEg6ZFhmP23ftMh7PxV4YKziN0qJ06eW+bXAZAqHz7DtkloS/MMw==
  • Delivered-to: orbit-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/orbit-dev>
  • List-help: <mailto:orbit-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/orbit-dev>, <mailto:orbit-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/orbit-dev>, <mailto:orbit-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVzL6GQEan6LmzGkq9VpkNYBiO3Q==
  • Thread-topic: switch from com.spotify.docker.client to org.mandas.docker.client
  • User-agent: Microsoft-MacOutlook/10.21.0.200104

I forgot to mention, but I had already opened a bug [1] for this.

 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=558284

 

From: "Homer, Tony" <tony.homer@xxxxxxxxx>
Date: Thursday, January 16, 2020 at 2:40 PM
To: Orbit Developer discussion <orbit-dev@xxxxxxxxxxx>
Subject: switch from com.spotify.docker.client to org.mandas.docker.client

 

I discussed this change with Roland at EclipseCon last year but haven’t had time to move forward until now.

 

In a nutshell, Spotify Docker Client is no longer being maintained [1].

As discussed in this issue [2], the damandalidis/dmandas fork [3] is bring actively maintained with an eye to staying ahead of the many CVEs in docker client dependencies.

I’d like to add org.mandas.docker.client and it’s updated set of dependencies to Orbit and update linux-tools Docker Tooling Support [5] to use it.

 

I updated create-docker-recipes.sh [6] to make a first pass at generating a recipe for this and it spit out a list of dependencies that will need recipes.

I took the list and compared with what is available in orbit and I’ll need to update 13 bundles and add 8 new bundles.

I’d like to add a README.md to the org.mandas.docker.client bundle which lists these dependencies and locations in orbit in order to ease maintenance going forward.

I’d like to land this set of changes for 2020-03.

 

Should I open 22 change requests (1 + 13 + 8), one giant change request for all of these changes or somewhere in between?

Should the obsolete Spotify Docker Client and/or it’s dependencies be removed from Orbit?

What other communications are needed (e.g., cross-project-issues-dev)?

Any other comments or guidance on this set of changes?

 

Thanks for reading.

Tony Homer

 

[1] https://github.com/spotify/docker-client/commit/14c955c0524233639fe76a35edda3d620037a525 

[2] https://github.com/spotify/docker-client/issues/1166

[3] https://github.com/dmandalidis/docker-client

[4] https://search.maven.org/artifact/org.mandas/docker-client

[5] https://www.eclipse.org/linuxtools/projectPages/docker/

[6] https://git.eclipse.org/c/orbit/orbit-recipes.git/tree/github/docker/create-docker-recipes.sh

 

Back to the top