Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[orbit-dev] Import-Package in osgi.bnd
  • From: "Homer, Tony" <tony.homer@xxxxxxxxx>
  • Date: Fri, 13 Dec 2019 01:12:57 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKRZ4SRbbazTURmEG4tfKnd80z7NSvlvoYEeNeyNyXg=; b=NWpwqbqlZHZDLlqKYX1pViFf2awPMUdG/YQk82aspObnc+SPvYtzPM30iBdqvcdIxVErGd+DWp5VP3bO0Z1aLFQidRno9XSuSpW5i53zFnylmkLpK6i7pjpUmAUFrMNmtvtAKo7Jv7Y7gQ+okuUWG9eliPdyValAQM7kitUDjUOIq79TYdhcRKA3rMljLHMByxdjUSm6tQ1VLUPw6MKhwUpOyrIW1VbKveKUi57axozx/OfdFwz5K726m2sTAdJzbwUcJDOgCvRYRjLin/dqK9oAaI0IUH3TNvM3eW1R0kWdlnCnxD6N00eB86Lfe9koUTy2cdJovgxKhHsyiGiyMA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCswEhDvrgeMESVXfL0taHG/WAUT6fhbih/oBEv1uDjwIeL1mPZQt2+sC8xUN/9n1r71myk5u2gTGmX3St+wvVlTAknr1jfx1q3DOVCnEAo5gY/AV8CEA4EFCi2VcWP8bXUq6m5PUhLf4NVDvlScqFuJR820NpWJHS8Jh/zfXHRGihvJCk3bdOkSN4hK1CMfCaXwE7t6/Y86pPzEyHPExVHhhmpKXs4B0lqca6UEGUhOppq0DiyWT0CkiG5tslJy1KgcyFWvp7BV/HdsGZdBFEzq65DqJEgT1E8g4DJqn32I4ndoRDFhyslYPMlbahZUftyxP76qo3mLNkUKK5mmlA==
  • Delivered-to: orbit-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/orbit-dev>
  • List-help: <mailto:orbit-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/orbit-dev>, <mailto:orbit-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/orbit-dev>, <mailto:orbit-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVsVJ0tPfmgEH4gk+q4WhN2+yJQw==
  • Thread-topic: Import-Package in osgi.bnd
  • User-agent: Microsoft-MacOutlook/10.20.0.191208

I’m working on a new recipe to address https://bugs.eclipse.org/bugs/show_bug.cgi?id=558284.

I used ebr to create the recipe and am working on reviewing osgi.bnd, specifically Import-Package.

In previous threads, IIRC, Roland Grunberg had advised me to pay special attention to Import-Package and Carston Reckord had suggested some ways to assemble the list of imports.

 

I used a regex search to find all of the import statements in all the java files, then trimmed from the last ‘.’ to the end of the line to get the package list (and sorted to get unique list, etc).

I was wondering about packages vs. subpackages because in some of the existing osgi.bnd files there seems to be a mix of toplevelpackage.* and toplevelpackage.subpackage.* in the Import-Package section.

I went to look at the bndtools doc (https://bnd.bndtools.org/heads/import_package.html) and it says “The default for this header is *, resulting in importing all referred packages. This header therefore rarely has to be specified.”

 

This is actually what ebr:create-recipe provides:

Import-Package: \

*

 

Can I get a refresher on what we need to have in Import-Package with regard to package vs. subpackage and why ‘*’ isn’t sufficient?

 

Thanks!

Tony Homer


Back to the top