Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] 2.1.0rc3 available 
My previous tests were with editline forced off.

Removing the forcing, and removing specifying paths -- because there is
libedit.pc in pkgconfig search path:

----------------------------------------
  prefix=/usr
  exec_prefix=${prefix}
  libdir=${exec_prefix}/lib
  includedir=${prefix}/include

  Name: libedit
  Description: command line editor library providing generic line editing, history, and tokenization functions.
  Version: 3.1
  Libs: -Wl,-R${libdir} -L${libdir} -ledit
  Libs.private: -ltermcap
  Cflags: -I${includedir} -I${includedir}/readline
----------------------------------------

I get

  -- Could not find libedit or readline library (missing: LINEEDITING_LIBRARIES LINEEDITING_INCLUDE_DIRS)

Adding to my pkgsrc Makefile:

  # upstream cmake fails to find libedit.pc
  CMAKE_CONFIGURE_ARGS+=  -DEDITLINE_DIR=${BUILDLINK_PREFIX.editline}
  CMAKE_CONFIGURE_ARGS+=  -DEDITLINE_INCLUDE_DIR=${BUILDLINK_PREFIX.editline}/${BUILDLINK_INCDIRS.editline}

I get

  -- Found LineEditing: /usr/lib/libedit.so

and in the build

  [190/792] Building C object apps/mosquitto_ctrl/CMakeFiles/ctrl_shell.dir/ctrl_shell.c.o
  FAILED: [code=1] apps/mosquitto_ctrl/CMakeFiles/ctrl_shell.dir/ctrl_shell.c.o
  /tmp/work/net/mosquitto/work/.cwrapper/bin/gcc -DCMAKE -DOPENSSL_API_COMPAT=0x10100000L -DVERSION=\"2.1.0\" -DWITH_CTRL_SHELL -DWITH_EDITLINE -DWITH_SOCKS -DWITH_THREADING -DWITH_TLS -DWITH_TLS_PSK -DWITH_UNIX_SOCKETS -I/tmp/work/net/mosquitto/work/mosquitt\
  o-2.1.0rc3 -I/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/common -I/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/include -I/tmp/work/net/mosquitto/work/.buildlink/include -O2 -pthread -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/python3.13 -I/u\
  sr/include/readline -Dz_off_t=long -std=gnu99 -MD -MT apps/mosquitto_ctrl/CMakeFiles/ctrl_shell.dir/ctrl_shell.c.o -MF apps/mosquitto_ctrl/CMakeFiles/ctrl_shell.dir/ctrl_shell.c.o.d -o apps/mosquitto_ctrl/CMakeFiles/ctrl_shell.dir/ctrl_shell.c.o -c /tmp/wor\
  k/net/mosquitto/work/mosquitto-2.1.0rc3/apps/mosquitto_ctrl/ctrl_shell.c
  In file included from /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/apps/mosquitto_ctrl/ctrl_shell.c:39:
  /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/apps/mosquitto_ctrl/ctrl_shell_internal.h:31:10: fatal error: editline/readline.h: No such file or directory
     31 | #include <editline/readline.h>
        |          ^~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  ninja: build stopped: subcommand failed.
  *** Error code 1


Reading cmake/FindLineEditing.cmake it seems to want to find
editline/readine.h and libedit, or readline/readline.h and libreadline.
That's good to find editline or readline, but it's failing with the
editline in its native environment, where one

  includes editline/readline.h
  links against editline

I am unclear on whether there is standard cmakery for this.
I'll ask for advice within NetBSD.
For now, I'll just leave editline forced off.

Back to the top