Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] 2.1.0rc3 available

Things are again very much improved v2->v3.  This is a report about
building and tests.   Then on to running it.

1) I was able to drop the forcing of --std=c++17.  (README-compiling.md
does not document C++17 but presumably cmake would error out and make
that obvious.)


2) On NetBSD 10 amd64, I see only one warning.

  [95/760] Building C object src/CMakeFiles/mosquitto.dir/mux_kqueue.c.o
  /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c: In function 'mux_kqueue__handle':
  /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c:189:53: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'short int' may change value [-Wconversion]
    189 |      loop_handle_reads_writes(context, event_list[i].filter);
        |                                        ~~~~~~~~~~~~~^~~~~~~

The problem is that struct kevent's filter member is uint32_t, while it
is "short" on FreeBSD.  However the valid values are 0U to 9U, so while
the compiler is sort of right, it failed to understand by static
analysis that it's always EVFILT_READ or EVFILT_WRITE, or maybe that's
not provable.  I don't see an operational problem, and suggest we figure
out a fix async from release.

3) On NetBSD 10 amd64, I am now down to 17 test failures

         13 - apps-passwd-changes (Failed)
         16 - broker-01-bad-initial-packets (Failed)
         55 - broker-02-subpub-qos2-max-inflight-bytes (Failed)
        141 - broker-08-ssl-bridge (Failed)
        194 - broker-09-plugin-evt-tick (Failed)
        221 - broker-14-dynsec-client-invalid (Failed)
        228 - broker-14-dynsec-group-invalid (Failed)
        237 - broker-16-config-huge (Failed)
        275 - broker-15-persist-bridge-queue-persist_sqlite (Failed)
        276 - broker-15-persist-client-drop-expired-messages-persist_sqlite (Failed)
        277 - broker-15-persist-client-expired-session-persist_sqlite (Failed)
        280 - broker-15-persist-client-msg-modify-acl-persist_sqlite (Failed)
        306 - client-02-subscribe-format (Failed)
        326 - client-03-publish-socks-no-auth (Failed)
        327 - client-03-publish-socks (Failed)
        330 - client-03-publish-tls (Failed)
        336 - client-04-rr-qos1-ws (Failed)

I will have a look and forward offlist, but assuming my testing
(multiple clients (including HA), incoming bridges) is ok, I lean to the
"these are test problems" theory, with some weight to "these are
problems in new features I don't use" theory.

4) On NetBSD 9 i386, I have a lot of warnings.

The size_t one is not a real problem on this platform, but changing to
%zd should avoid problems on all platforms.

(to be continued as I test more platforms, but wanted to send partial info)



[34/760] Building C object lib/CMakeFiles/libmosquitto.dir/loop.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/loop.c: In function 'mosquitto_loop':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/loop.c:130:26: warning: conversion to 'long int' from 'time_t {aka long long int}' may alter its value [-Wconversion]
  local_timeout.tv_nsec = (timeout_ms-local_timeout.tv_sec*1000)*1000000;
                          ^

[38/760] Building C object lib/CMakeFiles/libmosquitto.dir/net_ws.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c: In function 'net__read_ws':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:282:47: warning: conversion to 'size_t {aka unsigned int}' from 'uint64_t {aka long long unsigned int}' may alter its value [-Wconversion]
    mosq->wsd.out_packet = mosquitto_calloc(1, sizeof(struct mosquitto__packet) + WS_PACKET_OFFSET + mosq->wsd.payloadlen + 1);
                                               ^~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:297:11: warning: conversion to 'size_t {aka unsigned int}' from 'long long unsigned int' may alter its value [-Wconversion]
   count = mosq->wsd.payloadlen - (uint64_t)mosq->wsd.pos;
           ^~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:303:12: warning: conversion to 'size_t {aka unsigned int}' from 'long long unsigned int' may alter its value [-Wconversion]
    count = mosq->wsd.payloadlen - (uint64_t)mosq->wsd.pos;
            ^~~~

[67/760] Building C object src/CMakeFiles/mosquitto.dir/conf.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/conf.c: In function 'config__read_file_core':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/conf.c:2277:79: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t {aka int}' [-Wformat=]
       log__printf(NULL, MOSQ_LOG_ERR, "Error: Invalid 'memory_limit' value (%ld).", lim);
                                                                             ~~^
                                                                             %d

[72/760] Building C object src/CMakeFiles/mosquitto.dir/database.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~

[95/760] Building C object src/CMakeFiles/mosquitto.dir/mux_kqueue.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c: In function 'mux_kqueue__handle':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c:187:13: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     context = event_list[i].udata;
             ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c:189:40: warning: conversion to 'short int' from 'uint32_t {aka unsigned int}' may alter its value [-Wconversion]
      loop_handle_reads_writes(context, event_list[i].filter);
                                        ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/mux_kqueue.c:191:17: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      listensock = event_list[i].udata;
                 ^

[100/760] Building C object src/CMakeFiles/mosquitto.dir/__/lib/net_ws.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c: In function 'net__read_ws':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:282:47: warning: conversion to 'size_t {aka unsigned int}' from 'uint64_t {aka long long unsigned int}' may alter its value [-Wconversion]
    mosq->wsd.out_packet = mosquitto_calloc(1, sizeof(struct mosquitto__packet) + WS_PACKET_OFFSET + mosq->wsd.payloadlen + 1);
                                               ^~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:297:11: warning: conversion to 'size_t {aka unsigned int}' from 'long long unsigned int' may alter its value [-Wconversion]
   count = mosq->wsd.payloadlen - (uint64_t)mosq->wsd.pos;
           ^~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/lib/net_ws.c:303:12: warning: conversion to 'size_t {aka unsigned int}' from 'long long unsigned int' may alter its value [-Wconversion]
    count = mosq->wsd.payloadlen - (uint64_t)mosq->wsd.pos;
            ^~~~

[108/760] Building C object src/CMakeFiles/mosquitto.dir/persist_read.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c: In function 'persist__restore':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c:546:21: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
      if(fseek(fptr, length, SEEK_CUR) < 0){
                     ^~~~~~

[113/760] Building C object src/CMakeFiles/mosquitto.dir/plugin_v4.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_v4.c: In function 'plugin_v4_acl_check':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_v4.c:70:19: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
  msg.payloadlen = ed->payloadlen;
                   ^~

[114/760] Building C object src/CMakeFiles/mosquitto.dir/plugin_v3.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_v3.c: In function 'plugin_v3_acl_check':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_v3.c:70:19: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
  msg.payloadlen = ed->payloadlen;
                   ^~


[119/760] Building C object src/CMakeFiles/mosquitto.dir/plugin_acl_check.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_acl_check.c: In function 'plugin__acl_check':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/plugin_acl_check.c:114:19: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
  msg.payloadlen = payloadlen;
                   ^~~~~~~~~~

[153/760] Building C object src/CMakeFiles/mosquitto.dir/sys_tree.c.o
In file included from /usr/include/stdio.h:597:0,
                 from /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/sys_tree.c:24:
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/sys_tree.c: In function 'sys_tree__update':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/sys_tree.c:274:43: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int64_t {aka long long int}' [-Wformat=]
     len = (uint32_t)snprintf(buf, BUFLEN, "%lu", metrics[i].current);
                                           ^      ~~~~~~~~~~~~

[168/760] Building C object client/CMakeFiles/mosquitto_pub.dir/client_shared.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_load':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:487:35: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
    cfg->session_expiry_interval = UINT32_MAX;
                                   ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:490:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(cfg->session_expiry_interval == UINT32_MAX && (cfg->id_prefix || !cfg->id)){
                                    ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_line_proc':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1310:37: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
      cfg->session_expiry_interval = UINT32_MAX;
                                     ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1319:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      if(cfg->session_expiry_interval > UINT32_MAX || cfg->session_expiry_interval < -1){
                                      ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1325:38: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
       cfg->session_expiry_interval = UINT32_MAX;
                                      ^~~~~~~~~~

[169/760] Building C object client/CMakeFiles/mosquitto_pub.dir/client_props.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c: In function 'cfg_parse_property':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:180:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:188:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^

[170/760] Building C object client/CMakeFiles/mosquitto_sub.dir/sub_client.c.o

[172/760] Building C object client/CMakeFiles/mosquitto_sub.dir/client_shared.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_load':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:487:35: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
    cfg->session_expiry_interval = UINT32_MAX;
                                   ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:490:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(cfg->session_expiry_interval == UINT32_MAX && (cfg->id_prefix || !cfg->id)){
                                    ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_line_proc':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1310:37: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
      cfg->session_expiry_interval = UINT32_MAX;
                                     ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1319:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      if(cfg->session_expiry_interval > UINT32_MAX || cfg->session_expiry_interval < -1){
                                      ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1325:38: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
       cfg->session_expiry_interval = UINT32_MAX;
                                      ^~~~~~~~~~

[173/760] Building C object client/CMakeFiles/mosquitto_sub.dir/client_props.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c: In function 'cfg_parse_property':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:180:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:188:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^

[174/760] Building C object client/CMakeFiles/mosquitto_rr.dir/rr_client.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/rr_client.c: In function 'report_latency':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/rr_client.c:298:23: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'time_t {aka long long int}' [-Wformat=]
    printf("Latency: %ld.%09ld\n", s, ns);
                     ~~^
                     %lld

[177/760] Building C object client/CMakeFiles/mosquitto_rr.dir/client_shared.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_load':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:487:35: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
    cfg->session_expiry_interval = UINT32_MAX;
                                   ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:490:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(cfg->session_expiry_interval == UINT32_MAX && (cfg->id_prefix || !cfg->id)){
                                    ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c: In function 'client_config_line_proc':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1310:37: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
      cfg->session_expiry_interval = UINT32_MAX;
                                     ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1319:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      if(cfg->session_expiry_interval > UINT32_MAX || cfg->session_expiry_interval < -1){
                                      ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_shared.c:1325:38: warning: conversion of unsigned constant value to negative integer [-Wsign-conversion]
       cfg->session_expiry_interval = UINT32_MAX;
                                      ^~~~~~~~~~

[178/760] Building C object client/CMakeFiles/mosquitto_rr.dir/client_props.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c: In function 'cfg_parse_property':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:180:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/client/client_props.c:188:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if(tmpl < 0 || tmpl > UINT32_MAX){
                        ^

[224/760] Building C object plugins/examples/add-properties/CMakeFiles/mosquitto_add_properties.dir/mosquitto_add_properties.c.o
In file included from /usr/include/stdio.h:597:0,
                 from /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/add-properties/mosquitto_add_properties.c:37:
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/add-properties/mosquitto_add_properties.c: In function 'callback_message_in':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/add-properties/mosquitto_add_properties.c:63:31: warning: format '%li' expects argument of type 'long int', but argument 6 has type 'time_t {aka long long int}' [-Wformat=]
  snprintf(ts_buf, TS_BUF_LEN, "%li%03lu", ts.tv_sec, ts.tv_nsec / 1000 / 1000);
                               ^           ~~~~

[234/760] Building C object plugins/examples/limit-subscription-qos/CMakeFiles/mosquitto_limit_subscription_qos.dir/mosquitto_limit_subscription_qos.c.o
In file included from /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/include/mosquitto.h:27:0,
                 from /tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/limit-subscription-qos/mosquitto_limit_subscription_qos.c:34:
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/limit-subscription-qos/mosquitto_limit_subscription_qos.c: In function 'callback_subscribe':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/include/mosquitto/mqtt_protocol.h:291:49: warning: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Wconversion]
 #define MQTT_SUB_OPT_SET_QOS(opt, qos) ((opt) = ((opt) & 0xFC) | ((qos) & 0x03))
                                                 ^
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/examples/limit-subscription-qos/mosquitto_limit_subscription_qos.c:54:3: note: in expansion of macro 'MQTT_SUB_OPT_SET_QOS'
   MQTT_SUB_OPT_SET_QOS(ed->data.options, 1);
   ^~~~~~~~~~~~~~~~~~~~

[255/760] Building C object plugins/persist-sqlite/CMakeFiles/mosquitto_persist_sqlite.dir/restore.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/persist-sqlite/restore.c: In function 'json_to_properties':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/plugins/persist-sqlite/restore.c:152:48: warning: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Wconversion]
       ((uint8_t *)j_value->valuestring)[i/2] = (uint8_t)(hex2nibble(j_value->valuestring[i])<<4) + hex2nibble(j_value->valuestring[i+1]);
                                                ^
[455/760] Building C object test/unit/broker/CMakeFiles/persistence-read-obj.dir/__/__/__/src/database.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~

[458/760] Building C object test/unit/broker/CMakeFiles/persistence-read-obj.dir/__/__/__/src/persist_read.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c: In function 'persist__restore':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c:546:21: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
      if(fseek(fptr, length, SEEK_CUR) < 0){
                     ^~~~~~

[466/760] Building C object test/unit/broker/CMakeFiles/persistence-write-obj.dir/__/__/__/src/database.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~

[469/760] Building C object test/unit/broker/CMakeFiles/persistence-write-obj.dir/__/__/__/src/persist_read.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c: In function 'persist__restore':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/persist_read.c:546:21: warning: conversion to 'long int' from 'uint32_t {aka unsigned int}' may change the sign of the result [-Wsign-conversion]
      if(fseek(fptr, length, SEEK_CUR) < 0){
                     ^~~~~~

[483/760] Building C object test/unit/broker/CMakeFiles/subs-obj.dir/__/__/__/src/database.c.o
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:143:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes += client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:146:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 += client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_inflight_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:27: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                           ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:154:30: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->inflight_bytes -= client_msg->base_msg->data.payloadlen;
                              ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:30: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                              ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:157:33: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->inflight_bytes12 -= client_msg->base_msg->data.payloadlen;
                                 ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_add_to_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:165:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes += client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:168:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 += client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c: In function 'db__msg_remove_from_queued_stats':
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                         ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:176:28: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
  msg_data->queued_bytes -= client_msg->base_msg->data.payloadlen;
                            ^~~~~~~~~~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:28: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                            ^~
/tmp/work/net/mosquitto/work/mosquitto-2.1.0rc3/src/database.c:179:31: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion]
   msg_data->queued_bytes12 -= client_msg->base_msg->data.payloadlen;
                               ^~~~~~~~~~


Back to the top