Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] 2.1.0rc1 available for testing

Hi Roger, 

>> All the sqlite test cases fail with similar error messages:
> 
> I'm surprised any of the plugin tests work on mac actually - they all
> assume .so for the shared library ending.

The persist-sqlite plugin works now on macOS:

After adding the missing source file, mosquitto starts with persist-sqlite plugin (.so)
and all but one broker sqlite test cases pass.

Cheers,
   Christoph

************* Missing source in persist-sqlite/CMakeLists.txt:
```
diff --git a/plugins/persist-sqlite/CMakeLists.txt b/plugins/persist-sqlite/CMakeLists.txt
index ca081922..73ffc933 100644
--- a/plugins/persist-sqlite/CMakeLists.txt
+++ b/plugins/persist-sqlite/CMakeLists.txt
@@ -11,6 +11,7 @@ if(SQLITE3_FOUND)
                common.c
                init.c
                ../../common/json_help.c
+                ../../libcommon/cjson_common.c
                plugin.c
                restore.c
                retain_msgs.c
```
************* Failed Test Case:
```
262/281 Testing: broker-15-persist-client-expired-session-persist_sqlite
262/281 Test: broker-15-persist-client-expired-session-persist_sqlite
Command: "/Users/ckrey/mosquitto/test/broker/15-persist-client-expired-session.py" "persist_sqlite"
Directory: /Users/ckrey/mosquitto/builddevelop/test/broker
"broker-15-persist-client-expired-session-persist_sqlite" start time: Jan 24 11:53 CET
Output:
----------------------------------------------------------
memory queue, resubscribe = False, two_subscribers = False, num_retain_messages = 0
memory queue, resubscribe = True, two_subscribers = False, num_retain_messages = 0
memory queue, resubscribe = False, two_subscribers = True, num_retain_messages = 0
1769251996: Info: running mosquitto as user: ckrey.
1769251996: mosquitto version 2.1.0 starting
1769251996: Config loaded from 15-persist-client-expired-session_1888.conf.
1769251996: Bridge support available.
1769251996: Persistence support available.
1769251996: TLS support available.
1769251996: TLS-PSK support available.
1769251996: Websockets support available.
1769251996: Loading plugin: /Users/ckrey/mosquitto/builddevelop/plugins/persist-sqlite/mosquitto_persist_sqlite.so
1769251996: Plugin has registered to receive 'persist-restore' events.
1769251996: Plugin has registered to receive 'persist-base-msg-add' events.
1769251996: Plugin has registered to receive 'persist-base-msg-delete' events.
1769251996: Plugin has registered to receive 'persist-retain-msg-set' events.
1769251996: Plugin has registered to receive 'persist-retain-msg-delete' events.
1769251996: Plugin has registered to receive 'persist-client-add' events.
1769251996: Plugin has registered to receive 'persist-client-delete' events.
1769251996: Plugin has registered to receive 'persist-client-update' events.
1769251996: Plugin has registered to receive 'persist-subscription-add' events.
1769251996: Plugin has registered to receive 'persist-subscription-delete' events.
1769251996: Plugin has registered to receive 'persist-client-msg-add' events.
1769251996: Plugin has registered to receive 'persist-client-msg-delete' events.
1769251996: Plugin has registered to receive 'persist-client-msg-update' events.
1769251996: Plugin has registered to receive 'persist-will-add' events.
1769251996: Plugin has registered to receive 'persist-will-delete' events.
1769251996: Plugin has registered to receive 'tick' events.
1769251996: sqlite: Restored 100 base messages (0 failed)
1769251996: sqlite: Restored 0 retained messages (0 failed)
1769251996: sqlite: Restored 2 clients (0 failed)
1769251996: sqlite: Restored 2 subscriptions (0 failed)
1769251996: sqlite: Restored 120 client messages (0 failed)
1769251996: sqlite: Restored 0 will messages (0 failed)
1769251996: Expiring client test-expired-session-subscriber due to timeout.
1769251996: Opening ipv6 listen socket on port 1888.
1769251996: Opening ipv4 listen socket on port 1888.
1769251996: mosquitto version 2.1.0 running
1769251996: New connection from ::1:53615 on port 1888.
1769251996: Client ::1 closed its connection.
1769251996: New connection from 127.0.0.1:53616 on port 1888.
1769251996: New client connected from 127.0.0.1:53616 as test-expired-session-subscriber (p5, c0, k60, u'test-session-expiry').
1769251996: No will message specified.
1769251996: Sending CONNACK to test-expired-session-subscriber (0, 0)
1769251996: Received PINGREQ from test-expired-session-subscriber
1769251996: Sending PINGRESP to test-expired-session-subscriber
1769251996: mosquitto version 2.1.0 terminating
1769251996: Sqlite persistence: Closed DB

Traceback (most recent call last):
  File "/Users/ckrey/mosquitto/test/broker/15-persist-client-expired-session.py", line 135, in do_test
    check_db(
    ~~~~~~~~^
        persist_help,
        ^^^^^^^^^^^^^
    ...<6 lines>...
        retain_end=num_retain_messages,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/ckrey/mosquitto/test/broker/persist_module_helper.py", line 107, in check_db
    persist_help.check_client(
    ~~~~~~~~~~~~~~~~~~~~~~~~~^
        port,
        ^^^^^
    ...<9 lines>...
        will_delay_interval=0,
        ^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/ckrey/mosquitto/test/broker/persist_sqlite.py", line 235, in check_client
    raise ValueError(
    ...<2 lines>...
    )
ValueError: Invalid session_expiry_time 0 / 60 for client test-expired-session-subscriber

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/ckrey/mosquitto/test/broker/15-persist-client-expired-session.py", line 218, in <module>
    do_test(
    ~~~~~~~^
        "memory queue",
        ^^^^^^^^^^^^^^^
    ...<2 lines>...
        num_messages_two_subscribers=20,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/ckrey/mosquitto/test/broker/15-persist-client-expired-session.py", line 199, in do_test
    assert rc == 0, f"rc: {rc}"
           ^^^^^^^
AssertionError: rc: 1
<end of output>
Test time =   1.11 sec
----------------------------------------------------------
Test Failed.
"broker-15-persist-client-expired-session-persist_sqlite" end time: Jan 24 11:53 CET
"broker-15-persist-client-expired-session-persist_sqlite" time elapsed: 00:00:01
```





Back to the top