Re: [mosquitto-dev] 2.1.0rc1 available for testing

[Roger Light <roger@xxxxxxxxxx>]

On Tue, 20 Jan 2026 at 17:47, Greg Troxel via mosquitto-dev
<mosquitto-dev@xxxxxxxxxxx> wrote:

>There are a bunch of minor things to fix
> and I think an rc2 would be good.

I think it's looking that way.

>   - va_list was undefined because stdarg.h was not included.  I stuck it
>     in libcommon.h, not really the right place, but this needs fixing
>     somehow.

Fixed, thank you.

>   - There are a bunch of warnings about improper use of <ctype.h> macros
>     (which is UB).  The issue is that isspace etc. accept that argument
>     that is an int, and must have a value representable as unsigned char
>     or EOF.  A signed char becomes a negative int, which is not.  The
>     usual approach is to cast to unsigned char.

Noted - I'll get to them shortly.

>   - There are some other warnings,

Thanks for those.


>   - I didn't ask to test, but I got a failure because gmock was not
>     provided.  I think this is a cmake architecture bug, where it looks
>     in the filesystem and finds things and assumes they are part of the
>     build environment.  (pkgsrc has compiler wrappers that hide things
>     that are not declared dependencies, to get repeatable builds, and I
>     expect that other packaging systems will do this too.)  The fix is
>     to check for GTest by trying to build with it - but it is probably
>     better to note this in the README.

Testing is enabled unless you explicitly ask to turn it off, so I'd
expect an error. If you're still getting an error using
-DWITH_TESTS=OFF then that's definitely a concern. There's an argument
to be made about carrying on with some tests if gmock/gtest is not
there - I'd probably argue that if you want tests you want the whole
lot.

> => Full dependency libwebsockets>=4.3.0nb1: found libwebsockets-4.3.3nb1

Depending on what you want to support, libwebsockets is no longer
required. It's not only of interest if you need to serve files over
http. The built-in websockets support is better performance and
integrates better with the other options like certificates, that
libwebsockets didn't allow in the same way.

> |Provide a dir for capath, but do not set it.  (In mosquitto, having a
> |key/cert for the server is linked to having a CA, and to treating
> |clients with a certificate from a known CA as authorized.  This is
> |complicated, and not about pkgsrc, and this change does not intend to
> |step into the situation.)

This has not been the case for a long time now. You only need a
certfile and keyfile to configure a listener, unless you want client
certificates / mutual-TLS in which case you also need to set capath /
cafile.

I've also fixed a few of the parts you've reported Christoph. I'll
catch up with the other emails later this evening.

I've pushed the new fixes, once everything is addressed we can have rc2.

Regards,

Roger