Re: [mojarra-dev] [faces-dev] First Faces 4.0 proposals prototyped in My

[Thomas Andraschko <andraschko.thomas@xxxxxxxxx>]

Hi Arjan,

please see: https://github.com/eclipse-ee4j/mojarra/pull/4804

Would be great if we can merge it, so i can proceed.

Am Fr., 13. Nov. 2020 um 21:38 Uhr schrieb arjan tijms <arjan.tijms@xxxxxxxxx>:

Hi,

I took a look. It looks good, though specifically for the release method the javadoc needs some explanation. Specifically if FacesContext#release is required to call ExternalContext#release, and what, if anything, ExternalContext#release implementations are required to do.

Kind regards,

Arjan

On Fri, Nov 13, 2020 at 5:46 PM Thomas Andraschko <andraschko.thomas@xxxxxxxxx> wrote:

Hi Arjan,

could you maybe do a review here + port it to Mojarra?

If you dont have time to port, please let me know, i could work on a PR.

I would like to proceed with ClientWindowScope then.

Best regards,

Thomas

Virenfrei. www.avast.com

Am Fr., 30. Okt. 2020 um 16:09 Uhr schrieb Thomas Andraschko <andraschko.thomas@xxxxxxxxx>:

		Hi, i started some nobrainer here and would be great to get feedback. 1) Add "release" method to ExternalContext: Spec Issue: https://github.com/eclipse-ee4j/faces-api/issues/1498 Commit: https://github.com/apache/myfaces/commit/1c27e95cb4658fecd133d35888b46ac52a604718 2) API enhancements for Java8 Spec Issue: https://github.com/eclipse-ee4j/faces-api/issues/1497 Commit: https://github.com/apache/myfaces/commit/895fc4ebed67cf9de121157c1a3563490d4ea9b0
		Best regards, Thomas

_______________________________________________
mojarra-dev mailing list
mojarra-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mojarra-dev

_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev