| Re: [mdt-papyrus.dev] [PROVENANCE INTERNET] Re: [PROVENANCE INTERNET] Re: Oxygen.1 RC3 Regression in UseCasedropstrategy |
|
Hi Sebastien, An option is also to remove the strategy but I have no idea what this strategy is for and who is using it. I will raise the question in the Monday Cea meeting so we may know that.
Regards, Benoit De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de GERARD Sebastien Does the safe option mean tu let use case diagram editor as they are now with the Bug i raised? If yes, this latter is not usable! Envoyé depuis mon smartphone Samsung Galaxy. -------- Message d'origine -------- De : MAGGI Benoit <Benoit.MAGGI@xxxxxx>
Date : 11/09/2017 10:18 (GMT+01:00) À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : [PROVENANCE INTERNET] Re: [mdt-papyrus.dev] Oxygen.1 RC3 Regression in UseCasedropstrategy
Hi Camille, Thank you for your answer. Sadly, it won’t be so simple
L Your suggestion seems to patch the regression but… It seems that the drop strategy was already broken in Oxygen.0
(but for another use case added to the bug [1])
@Patrick: Since you asked to review all patches for Oxygen.1.
-
Can you enlighten me on what is expected with the drop strategy? (Here is the patch where you merged it [2]) -
Do we try to patch it for Oxygen.1? 3 options: o
Postponed it to 0xygen.2 (Safe) o
Integrate only the fix proposed by Camille (needs to be done today) o
Try a full patch (need the expected behavior and very risky)
As usual, I’m for the safe option
J Regards, Benoit 1:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=522028 2:
https://git.eclipse.org/r/#/c/48354/ De :
mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de Camille Letavernier Hi Benoit, A quick guess: since the Drop Framework did add support for Move Request (Adding the following test: RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()), the Strategy could check the request kind as well, and do nothing if it is
a Move request (Since, previously, it was not even called in case of Move). Something like that: public Command doGetCommand(Request request, final EditPart targetEditPart) { if (RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()){ return null; } [...] } The only other change in the Drop framework is related to drop Feedback (And formatting), which are probably not relevant in this case. But that's just a guess; I've not tested that HTH, On Fri, Sep 8, 2017 at 4:29 PM, MAGGI Benoit <Benoit.MAGGI@xxxxxx> wrote:
-- Camille Letavernier Senior Software Engineer Phone: +33 1 85 41 09 21 Hangouts:
cletavernier@xxxxxxxxxxxxxxxxx EclipseSource France SAS Palaiseau-Entreprises
7 rue de la Croix Martre 91120 Palaiseau General Manager: Remi Schnekenburger Registered Office: 7 rue de la Croix Martre, 91120 Palaiseau, France Commercial Register 824 977 516 R.C.S. EVRY |