Re: [mdt-papyrus.dev] Oxygen.1 RC3 Regression in UseCase drop strategy

[Camille Letavernier <cletavernier@xxxxxxxxxxxxxxxxx>]

Hi Benoit,

A quick guess: since the Drop Framework did add support for Move Request (Adding the following test: RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()), the Strategy could check the request kind as well, and do nothing if it is a Move request (Since, previously, it was not even called in case of Move).

Something like that:

public Command doGetCommand(Request request, final EditPart targetEditPart) {

if (RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()){

return null;

}

[...]

}

The only other change in the Drop framework is related to drop Feedback (And formatting), which are probably not relevant in this case.

But that's just a guess; I've not tested that

HTH,
Camille

On Fri, Sep 8, 2017 at 4:29 PM, MAGGI Benoit <Benoit.MAGGI@xxxxxx> wrote:

Hello,

 

Sebastien G. reported a bug to me this morning [1]?

In short a drop strategy in use case diagram duplicate the view.

 

I discovered that the default strategy for DropPolicy has been changed after Oxygen.0 [2].

I fear it’s too late to revert the change, so the best seems to change the drop strategies.

 

Did you discover more regressions in drop strategies?

(So far Sebastien also found one in SysML 1.4)

 

Did someone have a suggestion on what change should be applied

to this strategy UsecaseToSubjectinUsecaseDiagramDropStrategy

to be conform with the new default strategy?

 

Regards,

Benoit

1: https://bugs.eclipse.org/bugs/show_bug.cgi?id=522028

2: https://git.eclipse.org/r/#/c/102660/

 

 

_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev

--

Camille Letavernier

Senior Software Engineer
EclipseSource France

Email: cletavernier@xxxxxxxxxxxxxxxxx

Web: http://eclipsesource.com/paris

Phone: +33 1 85 41 09 21

Hangouts: cletavernier@xxxxxxxxxxxxxxxxx

EclipseSource France SAS

Palaiseau-Entreprises

7 rue de la Croix Martre

91120 Palaiseau

General Manager: Remi Schnekenburger

Registered Office: 7 rue de la Croix Martre, 91120 Palaiseau, France

Commercial Register 824 977 516  R.C.S. EVRY