Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [] Oxygen.1 RC3 Regression in UseCase drop strategy

Hi Camille,


Thank you for your answer. Sadly, it won’t be so simple L

Your suggestion seems to patch the regression but… It seems that the drop strategy was already broken in Oxygen.0

(but for another use case added to the bug [1])


@Patrick: Since you asked to review all patches for Oxygen.1.

-        Can you enlighten me on what is expected with the drop strategy? (Here is the patch where you merged it [2])

-        Do we try to patch it for Oxygen.1? 3 options:

o   Postponed it to 0xygen.2 (Safe)

o   Integrate only the fix proposed by Camille (needs to be done today)

o   Try a full patch (need the expected behavior and very risky)


As usual, I’m for the safe option J







De : [] De la part de Camille Letavernier
Envoyé : vendredi 8 septembre 2017 16:39
À : Papyrus Project list <>
Objet : Re: [] Oxygen.1 RC3 Regression in UseCase drop strategy


Hi Benoit,


A quick guess: since the Drop Framework did add support for Move Request (Adding the following test: RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()), the Strategy could check the request kind as well, and do nothing if it is a Move request (Since, previously, it was not even called in case of Move).


Something like that:


public Command doGetCommand(Request request, final EditPart targetEditPart) {

            if (RequestConstants.REQ_MOVE_CHILDREN.equals(request.getType()){

                        return null;






The only other change in the Drop framework is related to drop Feedback (And formatting), which are probably not relevant in this case.


But that's just a guess; I've not tested that




On Fri, Sep 8, 2017 at 4:29 PM, MAGGI Benoit <Benoit.MAGGI@xxxxxx> wrote:



Sebastien G. reported a bug to me this morning [1]?

In short a drop strategy in use case diagram duplicate the view.


I discovered that the default strategy for DropPolicy has been changed after Oxygen.0 [2].

I fear it’s too late to revert the change, so the best seems to change the drop strategies.


Did you discover more regressions in drop strategies?

(So far Sebastien also found one in SysML 1.4)


Did someone have a suggestion on what change should be applied

to this strategy UsecaseToSubjectinUsecaseDiagramDropStrategy

to be conform with the new default strategy?








_______________________________________________ mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit



Camille Letavernier


Senior Software Engineer
EclipseSource France


Phone: +33 1 85 41 09 21


EclipseSource France SAS


7 rue de la Croix Martre

91120 Palaiseau


General Manager: Remi Schnekenburger

Registered Office: 7 rue de la Croix Martre, 91120 Palaiseau, France

Commercial Register 824 977 516  R.C.S. EVRY

Back to the top