|Re: [mdt-ocl.dev] Playing with gerrit|
When we think that the new feature is ready, we prepare it for review by squashing the commits into a single one with a proper commit message, which we push for review. What you see in the review I've linked here (https://git.eclipse.org/r/#/c/13903/) is the result of such a squash.For a single change I certainly prefer to compare the start/finish; I don't have time to study the mistakes that were made along the way. Unfortunately Adolfo's second try at a review request failed to squash correctly, so I'm a bit worried that an intelligent user is making such a mess of a trivial change. I'm not impressed by the web interface to Gerrit and apparently there is no working EGIT integration, so I had to change to Eclipse, navigate to the file to verify that the Gerrit display was wrong.
It takes a while to familiarize with the Web UI of Gerrit... and even then it isn't that good a user experience. The Mylyn integration for gerrit seems quite good, but I haven't taken the time yet to check it out (http://www.eclipse.org/reviews/).
It's 'just' a matter of better discipline to try to avoid two improvements getting tangled, which is very difficult unless you have a very fast review response, and that is counterproductive because often I like an improvement to have a little time to settle since it was often triggered by another problem, and may deserve further work.
You can leave reviews pending for a long while, we actually do for some of ours. My "initial" process for working with Gerrit was quite messy, but it did the trick :
A better workflow is to really start taking advantage of branches.
begin:vcard fn:Laurent Goubet n:Goubet;Laurent org:<a href="http://www.obeo.fr">Obeo</a> email;internet:laurent.goubet@xxxxxxx url:http://www.obeo.fr version:2.1 end:vcard
Back to the top