Ed,
As I've understood from the thread, if we don't use package-import
with the 2.0.0 restriction for the google inject dependency, we
won't be affected.
On the other hand, the offending Orbit repository org.google.inject
bundle correspond to the Orbit RC3, so in principle it shouldn't
affect RC2.
Anyway, as you say the indigo aggregator build notified us in case
our contribution to the train were no consistent ;)
Cheers,
Adolfo.
El 23/05/2011 20:12, Ed Willink escribió:
Hi Adolfo
I hope that this doesn't affect us, since I think that our Xtext
dependencies are indirectly through Xtext so when Xtext changes we
change automatically, but it is possible that some P2 aggregation
may be too clever. May be best to do an RC2a once a compatible
Orbit and Xtext are available.
Regards
Ed
On 23/05/2011 20:02, David M Williams wrote:
Even fixing the
reported breakage may leave some users of com.google.inject broken. There's a number of
issues, and a confusing history (see Bug 346854), but as I understand things, the
summary is as follows.
The bundle version is
(correctly) "2.0.0". The packages are supposed to be exported
as "1.2", but until the latest build were being mistakenly
exported as "2.0". Apparently, this was known a while back,
fixed in CVS, but not "released to a build". While fixing
another bug, the "1.2" change was released (as well as not
exporting internals ... which is the breaking part for Sven
and team). So, I propose we immediately fix the "internals"
part, and still use the (correct) "1.2" version on package
exports. Hence, this will break anyone using "import package"
with a version restriction that used the previous "2.0". They
will need to adjust to import "1.2".
I think it best to fix the
exported version problem, and ask current clients that use
"import package" to adjust, since otherwise there is danger of
having conflicting versions of com.google.inject "in the
wild" which we can not do. I'm just glad this 1.2 vs. 2.0
issue was found before our final "release", even though it was
by accident. And apologies for breaking the export internals
part. The build with the changes is in progress and will be
available as an Orbit I-build approximately 5 PM (Eastern).
Once that build is confirmed, I'll rename/promote it to an new
S-build for clients to use for RC3 build. I'd expect that to
happen late tonight, or early tomorrow.
Thanks all for spotting, and
reporting.
Test early, test often! ... has
never been more true. :/
From: Sven Efftinge <sven.efftinge@xxxxxxxxx>
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date: 05/23/2011 02:22 PM
Subject:
Re:
[cross-project-issues-dev] Breaking changes in Orbit
Sent by:
cross-project-issues-dev-bounces@xxxxxxxxxxx
As we use require-bundle and not import-package,
the changed version (see the comments in the bug) in export
package shouldn't affect Xtext clients.
At least if you haven't switched to
import-package.
All we need to do is change the manifest in orbit
and add export-package declarations for the not-yet-exported
packages.
Sven
On May 23, 2011, at 7:22 PM, Miles Parker wrote:
Sven,
Do you have a sense for how these changes affect
xtext consumers? i.e. will we need to update manifests for any
xtext tooling derived projects?
thanks,
Miles
On May 23, 2011, at 5:17 AM, Sven Efftinge wrote:
Hi all,
I've filed Bug 346854 and just posting here, to make sure it is not
overlooked.
Some recently introduced changes to the manifest
of com.google.inject break the Xtext build.
We have switched back to a previous orbit build
for now, but we need to fix the issue ASAP.
Regards,
Sven
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
No virus found
in this message.
Checked by AVG - www.avg.com
Version: 10.0.1375 / Virus Database: 1509/3655 - Release Date:
05/23/11
_______________________________________________
mdt-ocl.dev mailing list
mdt-ocl.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev
|
