Re: [mdt-bpmn2.dev] Working on the ecore merger tool

[Benedikt Ritter <beneritter@xxxxxxxxxxxxxx>]

Hey,

the general question is, where are you going with the merger tool? Do
you want to use it for subsequent releases of the spec? Then the
project has to be in a maintainable state, with unit tests,
checkstyle, findbugs, etc.
Special configuration issues as mentioned by Henning should be
extracted from the code to some sort of config file (as far as
possible).

If on the other hand, migrating the ecore by hand to a new spec
release is far less effort then re-generating it and adjusting the
generated model, it should be considered to drop the merge tool
completely.

If you see a chance for bringing the tool up to date, then I'll start
right away, by writing some tests.

Benedikt


Am 30. März 2012 14:28 schrieb Henning Heitkötter <hheitkoetter@xxxxxxxxxxxxxx>:
> Hi all,
>
> I recently had a look at the merger tool and generated a merged Ecore
> file for testing purposes. I found that our ecore file has diverged
> from the automatically generated file in a lot of areas. (Of course,
> you can also look at the git log for the file to see these changes.)
> I also had some problems with attribute types (the ecore file that I
> had generated from the CMOF file only used EJavaObject), but that
> might have been due to some configuration issues on my side.
>
> While I think that bringing the merger tool up-to-date with these
> changes might be useful for future changes to the specification, be
> advised that it will likely require a lot of work and manual
> modification of the generated file (or special rules) might still be
> necessary, as not all changes can be deducted from the specification
> (CMOF + XSD) alone.
>
> Regards,
> Henning
>
> 2012/3/29 Hille-Doering, Reiner <reiner.hille-doering@xxxxxxx>:
>> Hi Benedikt,
>> I'm fine with the idea. Feel free to reorganize the project to fit to Maven convention structure. Only note that for bundles (for which we use tycho), the structure is different and more PDE like - and bundle tests go to extra bundles or fragments.
>>
>> Regards,
>>  Reiner.
>>
>>
>> Am 29.03.2012 um 22:40 schrieb "Benedikt Ritter" <beneritter@xxxxxxxxxxxxxx>:
>>
>>> Hi,
>>>
>>> I'm planning to put some effort on the ecore merger tool, since there
>>> are several issues related with that tool (e.g.
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=357088 or the discussed
>>> splitting of the ecore model). However, I'm feeling uncomfortable,
>>> touching the code because there are no unit tests. So the first thing
>>> I want to do is to write some unit tests.
>>> Now at my company we use maven. Maven has a convention for the project
>>> structure, where unit tests reside in special source folder called
>>> src/test/java. Since the ecore merger tool does not stick to this
>>> convention, I do not know where to put my unit tests. I've seen the
>>> test bundle but I don't think that it is the right place for the ecore
>>> merger unit tests. So where should I put the tests?
>>>
>>> After bulding up a basic test coverage (and ATM I don't know how much
>>> effort that will be), I'd like to try to split the code up some more.
>>> The processor has several concerns that it has to deal with, and it
>>> would be good to separate concerns.
>>>
>>> Regards,
>>> Benedikt
>>> _______________________________________________
>>> mdt-bpmn2.dev mailing list
>>> mdt-bpmn2.dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/mdt-bpmn2.dev
>> _______________________________________________
>> mdt-bpmn2.dev mailing list
>> mdt-bpmn2.dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mdt-bpmn2.dev
> _______________________________________________
> mdt-bpmn2.dev mailing list
> mdt-bpmn2.dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mdt-bpmn2.dev