Re: AW: [mdt-bpmn2.dev] Build fix

[Tammo van Lessen <tvanlessen@xxxxxxxxx>]

Hi Reiner,

I think the ||= was a typo. It didn't break the build but emptied the
list of repositories. I think it however intended to add them to a
potentially existing list, via |= (union).

The other thing might be either a windows or a config issue. I read
somewhere that FileUtils.makedirs is better than File.makedirs as this
woudl depend on ftools and the use of ftools is not recommended.
Whatever... my patch is of course just a proposal and I'm sure Antoine
knows better about ruby magic than I do. I for me was happy that I could
build it after applying these fixes on my machine and thus I wanted to
share it with you guys :)

And somehow it looks like that I'm experiencing the strangest buildr
problems the buildr team could ever imagine ;)

Best,
  Tammo

On 06.08.2010 17:58, Hille-Doering, Reiner wrote:
> Hi Tammo,
> I'm happy that you like the stuff.
> About the build: I'm sure that Antoine could incorporate your proposal. However, we already have working build on this Hudson:
> https://build.eclipse.org/hudson/job/buildr-bpmn2-0.7-nightly/ws/
> If the build script is wrong, why does it successfully build?
> 
> Thanks and regards,
>  Reiner.
> 
> 
> -----Ursprüngliche Nachricht-----
> Von: mdt-bpmn2.dev-bounces@xxxxxxxxxxx [mailto:mdt-bpmn2.dev-bounces@xxxxxxxxxxx] Im Auftrag von Tammo van Lessen
> Gesendet: Freitag, 6. August 2010 17:04
> An: mdt-bpmn2.dev@xxxxxxxxxxx
> Betreff: [mdt-bpmn2.dev] Build fix
> 
> Hi guys,
> 
> first off, thanks for the great model. I assume it will still need
> some love but I'm happy to have a comprehensive model.
> 
> I tried to build the stuff but experience some troubles with the build
> file. Please find attached a patch that fixes some JRuby issues
> (File.makedirs -> FileUtils.makedirs).
> 
> Are the any plans to push this to a m2 repository?
> 
> I hope I don't need to sign a CLA or to file a bug or something.
> 
> Thanks,
>   Tammo
> 

-- 
Tammo van Lessen - http://www.taval.de