Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] Comments on Bug 470138

I have made a few more enhancements to the "Phase and Goals" and published it on Eclipse Marketplace in case folks want to try it easily.

https://marketplace.eclipse.org/content/phases-and-goals

Please note that you need to configure Maven 3.3.1+ for the Launch command to work (due to need to be able to specify execution id with the goal).

On Wed, Jun 17, 2015 at 10:56 AM, Sandip Chitale <sandipchitale@xxxxxxxxx> wrote:
It is my understanding that (which may be incomplete and/or incorrect) that the execution of a build only happens in terms of goals i.e. if you executed all goals (explicitly) of all preceding phases and the intended phase in sequence you will achieve the same result. It is true that some state may get passed between them via reactor in-memory context or some such, which could be a problem. All that is understood.

I think the user will use the functionality under discussion with the knowledge that prerequisites must be satisfied. Assuming that is true and the user has considered all of that and made sure the prerequisites are satisfied, they may choose to use selective run functionality. It is true though that it may still not work in some cases because in memory state that needs to present which is set by goals in preceding phase may not be present in selective run scenarios - too bad for that use case. Hopefully the user will find that out quickly and not use this functionality.

Sandip

On Wed, Jun 17, 2015 at 7:42 AM, Endo Alejandro <Alejandro.Endo@xxxxxxxxxxxxxxx> wrote:

Ah, I understand. You are running just the mojos, not the actual phases. That sounds interesting. Let me ask you or anyone else, aren’t some of the mojos that attach to the lifecycle, specific to the lifecycle and cannot be used standalone? I’m pretty sure I remember seeing some plugins having equivalent mojos for lifecycle-bound mojos and for CLI mojos. If that is the case, you are going to detect in your new feature mojos that are lifecycle-bound mojos and try to run them standalone. Would that be a problem?

 

 

Alejandro

 

 

 

From: m2e-users-bounces@xxxxxxxxxxx [mailto:m2e-users-bounces@xxxxxxxxxxx] On Behalf Of Sandip Chitale
Sent: Monday, June 15, 2015 12:32 PM
To: Maven Integration for Eclipse users mailing list
Subject: Re: [m2e-users] Comments on Bug 470138

 

I perfectly understand that when the user invokes maven with a phase name, as it stands today, all the preceding phases are run. It is also true that you can invoke a single goal by specifying it. You can specify multiple goals also. With the new syntax of being able to pass the execution id along with the goal you can also run non default-* it is basically possible to run any specific goal. (See: https://issues.apache.org/jira/browse/MNG-5768 as implemented in Maven 3.3.1.

 

I think you may agree that a single goal execution is basically random-access. What I am proposing is simply a shortcut, self maintaining way to invoke each of these goals by simply specifying the phases. The phases of a lifecycle are more stable. Goals generally are configured in poms and are thus may change over time.

 

Granted, this may not work for users 100% of the time but when it works it is useful IMO.

 

I had mentioned in one of the previous blog entries that I was in-fact inspired by the Lifecycle mapping functionality of M2E.

 

I also agree that this belongs may be at the maven level via some modified/extended syntax of maven CLI. However when I attempted to enhance the 

 

> mvn help:describe --Dcmd=somephase

 

I did not get far. So I was able to put this together with M2E fragment - based on the code I saw in Life Cycle Mapping property page in M2E. This renders the use of my fragment to interactive use for now.

 

It is possible that this idea is too radical for M2E or maven community in which case it will have a deserved rejection in the marketplace of ideas :)

 

I will update my blog entry and the bugzilla to explain the thinking behind this better.

 

Hope this clarifies where I am coming from at this.

 

Cheers,

Sandip

 

 

On Mon, Jun 15, 2015 at 8:24 AM, Endo Alejandro <Alejandro.Endo@xxxxxxxxxxxxxxx> wrote:

Without understanding 100%, this sounds like it would be VERY brittle. What exactly are you trying to accomplish with the new functionality? I didn’t see that in your blog post

 

Also, AFAIK, maven core doesn’t support running only parts of its lifecycle, how can your patch do that? (e.g. run “package” without running “compile” first). Maybe if you explain a bit how this fits maven (nothing to do with m2e) then we can understand better, but it sounds like you are just breaking the maven lifecycle, or am I missing something? A lot of plugins and mental models assume that the lifecycle is linear, not “random-access”

 

BTW, all that was about running particular phases without their previous ones. The first part about listing the mojos in each phase is very useful, but I also wonder how it’s different from the current m2e functionality on “Lifecycle Mapping”.

 

Once I/we understand better I/we can give a more informed opinion.

 

Thank you,

 

 

Alejandro

 

From: m2e-users-bounces@xxxxxxxxxxx [mailto:m2e-users-bounces@xxxxxxxxxxx] On Behalf Of Sandip Chitale
Sent: Sunday, June 14, 2015 07:53 PM
To: m2e-users@xxxxxxxxxxx
Subject: [m2e-users] Comments on Bug 470138

 

Hi everyone,

 

I am trying to gauge support for feature like

 

 

Can the community please comment on the bug. In a nutshell the idea is to be able to run selective phases (sans preceding phases) of a pom.

 

Thanks in advance,

Sandip

DISCLAIMER: Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You.


_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-users

 

DISCLAIMER: Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You.


_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-users



Back to the top