Re: [lyo-dev] Support for Oauth in the oslc4j-client library

[Andrii Berezovskyi <andriib@xxxxxx>]

Hi,

Just for everyone paying attention to the mailing list and not to Github, I reviewed the PR and it looks good. I have a comment regarding the change of interface yet again (I am guilty of doing it the first time) and not having an ability to interchange different Client instances.

I have suggested adding an interface that would then be implemented. Jad explained to me that it won't be as easy as we need interruptible operations in OAuth-enabled client. We started thinking about returning LyoResponse<T> instead of T so that it would be similar to JAX-RS Response. To be contd.

--
–Andrew.

On 2019-09-30 , at 23:48, Jad El-Khoury <jad@xxxxxx> wrote:

Dear all,

 

After migrating the Lyo client to use JAX-RS 2.0, I thought it’s time to introduce support for the client to handle Oauth. This is essential if you need to communicate with any real implementations of OSLC servers.

 

I have an working initial implementation in place. Anyone interest in this code, that would also be willing to review/test it?

 

https://github.com/eclipse/lyo.client/pull/77

regards

______________________________

Jad El-khoury, PhD

KTH Royal Institute of Technology

School of Industrial Engineering and Management, Mechatronics Division

Brinellvägen 83, SE-100 44 Stockholm, Sweden

Phone: +46(0)8 790 6877 Mobile: +46(0)70 773 93 45

jad@xxxxxx, www.kth.se

 

_______________________________________________
lyo-dev mailing list
lyo-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/lyo-dev