Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4e-dev] Issue with code formatting in LSP4E in Eclipse 19-09
  • From: "Ofterdinger, Markus" <markus.ofterdinger@xxxxxxx>
  • Date: Fri, 11 Oct 2019 08:49:01 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E8sitwsVPFzuS/1fuoUUXNnBKrFK62qvo0/Xg/TDfNU=; b=LF9KsYULE0XV798v3dqo9JEl8ePDc0hg2XHIcctD6ir1Bh43GzWjzlwNmTFre/wLUJbkYWdGMb0HtpTFaWIsvwCy/SX0ZSOIJm1txm1Uh6JG1bEH+ZCzIAM4RPZNvY8jIe1jKTNiZ9dNXEElVzeqYjFxasZOsVqgryU7FBVgJxTZSRnvLQTwlg+srNMzsqLI0kV1mIUJwNGV4N2jTTwSCqI2PWwqz/BJPg4Q3hvicGzqrEYYj+f7nVTv5cHMvJLt36T+YS700RI4nKwbePvJ1KcgGaGMoHjKX5ykGhsbXBu9w5UEfQ+NaExuyB5kH4JnE1+gtxF28rV9Sss95r76RQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+4M01lH1d0M6nVderdu/vAHtO/OZUAs4pCKN+M67Sjn3glB2X2GJFmn/SpeRCPSHZ56xcU6WazCCh1dJxgXsutyUOpI99XsfZBB5FBnguYzUVk9PJ5maxYe8Vzggo+tMV81X/gT3xAOEsvGmMFP6GLsphpvjI1U+h7rOGocx0SVWcrAa44mG5umyTk4K1thJzL6knzG2BzhgLoy1X08lTpm2w9Y2Dg/++H2AugqlKcuPEiBOskUH9o/TSE3rWHGiV+OQqiG04G+CgjZnYGI7oXrjq+WOTcUG/HDBVJALLB/FYuYa1lisk2oEsX1t4sfjwrQzhjIpGg7EYPZCDW/3Q==
  • Delivered-to: lsp4e-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/lsp4e-dev>
  • List-help: <mailto:lsp4e-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVgAWZypVPNZSe6EOsGcNUgHp7g6dVDFqAgAAnQwD//9/MgIAAKFuA///gGQCAACcTgA==
  • Thread-topic: [lsp4e-dev] Issue with code formatting in LSP4E in Eclipse 19-09
  • User-agent: Microsoft-MacOutlook/10.1e.0.191003

You are right, it looks like the CDS language server doesn’t send these capabilities in the init response on Eclipse 19-09:

 

"documentFormattingProvider":true,

"documentRangeFormattingProvider":true,

"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"}",

"moreTriggerCharacter":[";"]},

 

I assume those flags are required to enable the code formatting feature in the generic editor?

 

I’m on the latest LSP4E release:

                Eclipse.org           Language Server Protocol client for Eclipse IDE (Incubation)          0.12.0.201909270706                org.eclipse.lsp4e

 

We have to figure out internally why those capabilities are missing.

 

Thanks for your hints!!

 

From: <lsp4e-dev-bounces@xxxxxxxxxxx> on behalf of Mickael Istria <mistria@xxxxxxxxxx>
Reply to: lsp4e developer discussions <lsp4e-dev@xxxxxxxxxxx>
Date: Friday, 11. October 2019 at 10:30
To: lsp4e developer discussions <lsp4e-dev@xxxxxxxxxxx>
Subject: Re: [lsp4e-dev] Issue with code formatting in LSP4E in Eclipse 19-09

 

Looking at the logged message should be enough.

I guess the language server forgets to send the dynamicRegistration, or you're using a version of LSP4E that's older than https://git.eclipse.org/c/lsp4e/lsp4e.git/commit/?id=73a578f24d48c010c62df21a0f53e639b691ad76

Back to the top