Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [kura-dev] ConfigurableComponents

> As I see it, and maybe I am wrong with that, all added functionality of Kura to the configuration system is actually targeted at the storage layer of the ConfigurationAdmin. However the current ConfigurationService is creating a complete duplication of the whole configuration system of OSGi


I agree. We have an open issue on Github dedicated to the ConfigurationService.


Ciao,

  Cristiano


Da: kura-dev-bounces@xxxxxxxxxxx <kura-dev-bounces@xxxxxxxxxxx> per conto di Jens Reimann <jreimann@xxxxxxxxxx>
Inviato: mercoledì 5 ottobre 2016 18.09.01
A: Kura Developers mailing list
Oggetto: Re: [kura-dev] ConfigurableComponents
 
Hi David,

I completely understand that they are critical. And removing them is not an option! I agree!

However I do think that they could be implemented other on top of the ConfigurationAdmin, or be having a custom implementation of ConfigurationAdmin. Possibly enhancing something like an existing implementation like Apache Felix CM.

As I see it, and maybe I am wrong with that, all added functionality of Kura to the configuration system is actually targeted at the storage layer of the ConfigurationAdmin. However the current ConfigurationService is creating a complete duplication of the whole configuration system of OSGi. Replicating configuration data back and forth between two services. All OSGi tools will target the official OSGi API. So supporting that API will benefit Kura more than a custom API, IMHO.

However that standard OSGi implementation does need to support snapshots and encryption, I completely agree here!

On the other hand, it you don't need that added functionality, you would be able to use Kura without that added functionality and simply stick to the "default" OSGi implementation.

Looking at the default storage interface of Apache Felix CM [1], I think having an alternative implementation should be rather easy.

Cheers

Jens

On Wed, Oct 5, 2016 at 5:54 PM, Woodard, David <david.woodard@xxxxxxxxxxxx> wrote:
Hi Jens,

I think we agree that the handling of bundle configurations could be done better. However, I see the snapshot and rollback features as being critical to Kura. Are you proposing to remove those features or are you saying that Apache Felix ConfigAdmin already has similar extensions?

--Dave

On Oct 5, 2016, at 03:47, Jens Reimann <jreimann@xxxxxxxxxx> wrote:

I would really like to see this. Actually I do think that the whole custom Kura configuration service implementation could be switched to using the native OSGi ConfigurationAdmin implementation. That would make life lot easier and beside the "snapshot and rollback" functionality and the "encryption" feature I don't see any added benefit.

But I think that both features could be built base on an Apache Felix ConfigAdmin, providing a cleaner overall setup and allowing other configuration paths like Apache Karaf, or FileInstall.

And yes, we could then also go for custom types and don't run into the issue anymore that a misconfigured service cannot be reconfigured anymore.

+1 from me .. maybe someone should create on issue for that.

On Tue, Oct 4, 2016 at 7:01 PM, Lewis, ScottX <scottx.lewis@xxxxxxxxx> wrote:
Thanks David and Jens.  I understand and have been successful using the heater example.  Works great, thanks.  

One question:   Is there some indication somewhere of the available ui widgets associated with the various types? (Integer and String are understood, but are there widget for other types...e.g. Double/Float, and possibly even List/Collection/Map?

I assume that once Kura moves to DS version 1.3 (and associated metatype) that we will be able to use custom types for the ConfigurableComponents...e.g. as described in [1].   Is that a reasonable assumption?   Also, I expect you know this...but Equinox is moving to the Felix SCR impl (1.3 I believe) for Oxygen [2].

Scott



From: kura-dev-bounces@xxxxxxxxxxx [kura-dev-bounces@xxxxxxxxxxx] on behalf of Jens Reimann [jreimann@xxxxxxxxxx]
Sent: Monday, October 03, 2016 11:53 PM
To: Kura Developers mailing list
Subject: Re: [kura-dev] ConfigurableComponents

The most important things to remember here are:

* Your service must be registered with the OSGi service layer, just declaring the service is not enough
* You must also set the configuration policy to "required"
* The service must have a "service.pid"
* There must be a metatype descriptor of exactly that "service.pid" (see the example as a reference)

Leaving out any of those will cause the service to not be shown in the Web UI.

Also be aware of the fact that if you configure something wrong, so that the service gets unregistered with OSGi, then also the configuration UI will disappear, and you cannot undo that mistake.

Cheers

Jens

On Mon, Oct 3, 2016 at 9:09 PM, Woodard, David <david.woodard@xxxxxxxxxxxx> wrote:
Hi Scott,

Yes, that is one of the primary reasons for the ConfigurableComponent interface. Most of the examples in the Kura repo do exactly what you describe. Probably the simplest is the heater demo [1].


Thanks,
--Dave

On Oct 3, 2016, at 14:01, Lewis, ScottX <scottx.lewis@xxxxxxxxx> wrote:

Howdy,

Are there Kura examples that show the use of the org.eclipse.kura.configuration.ConfigurableComponent?

Is it possible to plugin to the kura web interface using ConfigurableComponent?  i.e.  so that we can create/add a service that is a ConfigurableComponent, and the ui will appear in web Services section...provide a UI, and allow the configuration of our service similar to ClockService, MqttDataTransport service, PositionService, etc?   If that's a possibility, any examples of doing that?

Thanksinadvance,

Scott

_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev


_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev



--
Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev



--
Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill
_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev


_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev



--
Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

Back to the top