Re: [kura-dev] Eclipse formatter files

[Jens Reimann <jreimann@xxxxxxxxxx>]

Hi,

I just tried out both files and I would like to suggest the following changes:

* Don't sort fields and members, because this can actually change the behavior of the application

* Always prefix fields with "this"

* Don't align fields, this can get really messy with generics:
---
    private final static Logger                       logger = LoggerFactory.getLogger(CloudClientCacheImpl.class);
    private final CloudService                        cloudService;
    private final Map<String, Set<CloudClientHandle>> cache  = new HashMap<String, Set<CloudClientHandle>>();
---

What do you think?

Jens

On Tue, Aug 23, 2016 at 3:36 PM, Maiero, Matteo <matteo.maiero@xxxxxxxxxxxx> wrote:

Hi Jens,

attached the mentioned files.

Best regards,

Matteo

-- 

Matteo Maiero
Software Engineer

direct: +39 0433 485 902

email: matteo.maiero@eurotech.com

EUROTECH

Imagine.Build.Succeed.

HEADQUARTERS

EUROTECH S.p.A. – Via Fratelli Solari, 3/a | 33020 Amaro UD | Italy | Tel. +39. 0433 485411  | Fax +39. 0433 485499 |

Cap. Soc. 8.878.946,00 € I.V. | P.IVA / C.F.: IT 01791330309 | REA Udine 196115
www.eurotech.com
____________________________________

Il presente messaggio ed ogni suo allegato sono da intendersi inviati esclusivamente agli effettivi destinatari e potrebbero essere soggetti a restrizioni legali. Se avete ricevuto questo messaggio per errore vi invitiamo a darne immediata notifica al mittente e cancellarlo dal vostro sistema. Qualsiasi altro uso di questo messaggio da parte vostra e' strettamente proibito.

 

This e-mail, and any file attached to it, is meant only for the intended recipient of the transmission and may be a communication privileged by law. If you have received it in error, please notify the sender immediately and delete the original from your system. Any other use of this e-mail by you is strictly forbidden.

--

Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill