I suggest reverting and thinking it over. As this change was really easy and small.
From: "kapua-dev-bounces@xxxxxxxxxxx" <kapua-dev-bounces@xxxxxxxxxxx> on behalf of Jens Reimann <jreimann@xxxxxxxxxx>
Reply-To: kapua developer discussions <kapua-dev@xxxxxxxxxxx>
Date: Wednesday, June 28, 2017 at 10:38 AM
To: kapua developer discussions <kapua-dev@xxxxxxxxxxx>
Subject: Re: [kapua-dev] Issues with unit test/integration test split
I am not sure if we should really postpone this for too long, as we currently are in the situation
1) That we cannot run all unit tests in a single build
2) That we cannot properly run a full build specifying -Dtest= because this fails the build
3) There is dropped code coverage for PRs and other build systems
Maybe we should think about reverting this change for the moment and make a proper plan how we want to continue splitting up tests.
Or maybe, there is a workaround to the current situation. Then please let me know.
Cheers
Jens
On Wed, Jun 28, 2017 at 10:27 AM, Uroš Mesarič Kunst <Uros.Mesaric-Kunst@xxxxxxxxxxxx> wrote:
I agree that tests have to be run.
Maybe we could discuss aproach on Thursday.
All tests should be run by Travis on PR.
Local build (mvn clean install or mvn test) should skip integration tests.
Hudson CI should skip integration tests on each commit, but should run all the tests on nightly build.
Uroš
I do have some issues with the recent split of unit tests and intgration tests.
From what I have seen the way to go is to specify "-Dtest=integration" for running the integration tests.
However, seeing a drop in code coverage, this seems to disable the unit tests. And looking at the maven profiles, it seems as if there is currently no way to run unit tests and integration
tests in the same build.
I would strongly suggest to revert this behavior and fall back to the maven standard way of using "test" and "integration-test", maybe using the "failsafe" plugin and allow to run both
test types when desired in a single build.
Cheers
Jens
--
Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________
Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill
_______________________________________________
kapua-dev mailing list
kapua-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kapua-dev
--
Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________
Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill
|
