[jta-dev] Requesting a project committer to review a PR (was Re: Pull re

[Tom Jenkinson <tom.jenkinson@xxxxxxxxxx>]

I have raised a pull request that includes a solution for this. I would like to request a review from a project committer [1] for the pull request [2] even with it's more full scope, please?

[1] https://projects.eclipse.org/projects/ee4j.jta/who

[2] https://github.com/jakartaee/transactions/pull/234

On Wed, 10 Jun 2020 at 15:13, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:

I raised an issue about discussing merge conditions for a PR: https://github.com/eclipse-ee4j/jta-api/issues/100

On Mon, 8 Jun 2020 at 17:01, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:

Hi,

I have received a review from a person that is not a committer to the Jakarta Transactions project on a pull request [1]. However, unless I hear any objection by Thursday 11th June, 2020 I intend to merge the pull request.

I think we should also add something to https://github.com/eclipse-ee4j/jta-api/blob/master/CONTRIBUTING.md to formalise these kind of conditions.

If you are a committer [2] to Jakarta Transactions and would like to provide a review in the meantime, that would be appreciated too.

Thanks!

Tom

[1] https://github.com/eclipse-ee4j/jta-api/pull/97

[2] https://projects.eclipse.org/projects/ee4j.jta/who