Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jta-dev] Requesting committer review request
I did find a couple of instances of "JTA" and "Java Transaction", which I flagged up. I'm otherwise ok with the PR.

Hope that helps.

Jon

On Mon, Jul 15, 2019 at 12:47 PM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Thanks Jon, I have added some comments too.

On Mon, 15 Jul 2019 at 12:08, Jonathan Gallimore <jgallimore@xxxxxxxxxxxxx> wrote:
I'll have another look after lunch - I did pick up a couple of points - one was the copyright in the files - should this be (c) 2012 - 2019 across the board? The other was the api pom, I think it has the wrong parent. I'm guessing it should be the Jakarta Transactions Parent.

All builds ok and the PDF looks great.

Jon

On Mon, Jul 15, 2019 at 11:04 AM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Thanks!

On Mon, 15 Jul 2019 at 10:43, Jonathan Gallimore <jgallimore@xxxxxxxxxxxxx> wrote:
Sure thing! I'm taking a look now.

Jon

On Mon, Jul 15, 2019 at 10:34 AM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Hi,

I have a pull request out on Jakarta Transactions to help prepare for the Jakarta EE 8 release [1]. Please can I ask a committer from the project to provide a review so I can merge it?

Thanks,
Tom

_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jta-dev


--
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jta-dev
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jta-dev


--
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jta-dev
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jta-dev


--
Jonathan Gallimore
http://twitter.com/jongallimore

Back to the top