Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jifa-dev] Hook support for customisation of JIFA deployment


On Sun, Aug 30, 2020 at 10:02 PM Denghui Dong <denghui.ddh@xxxxxxxxxxxxxxx> wrote:
Hi Jason,

The idea of adding a hook layer to satisfy customer requirements is interesting okay for me.


Great.
 
I noticed that you added access control in NetflixHooks, actually, in our current design,
we put the implementation of access control to the "Master" which will be opened source recently.


Yes I think this is ideal. It does not matter what requirements a user has in their deployment, with some pre/post route changes, they can do what they need to do without modifying JIFA core.
 
And I think the customer implementation of the hook should be maintained by users themselves,
only empty implementations should be reserved in the public repository.

Of course, I definitely agree with that. Only provided Netflix as a sample to show what could be done.
 
Could you file an issue on https://github.com/eclipse/jifa/issues?

We need to have further communication on this issue

Sure.
 
Thank you for your interest in Jifa!

Thanks
Denghui


------------------------------------------------------------------
From:Jason Koch <jkoch@xxxxxxxxxxx>
Send Time:2020年8月26日(星期三) 03:24
To:jifa-dev <jifa-dev@xxxxxxxxxxx>
Subject:[jifa-dev] Hook support for customisation of JIFA deployment

Thank you for releasing JIFA, it's a really great solution, and I had started working on something similar but your UI is clean and great for MAT users. Excellent work!

For Netflix we have a number of deployment requirements, including securing heapdumps, storage of files in S3, that require some customization.

I have created a hooks layer that can be used to override default behavior of JIFA at specific points in application:
- custom vertx HttpServerOptions
- route customisation
- directory/file mapping customization

I have the diff here with all the customizations we use to have it deployed:

With this diff applied, anyone can create a class that "implements JifaHooks" and set worker-config.json and any custom code will be executed:
"hooks.className": "foo.bar.HooksClass"

We use this for:
- custom handling of file system paths (so it is not in the eclipse workspace) and integration to S3
- custom authorization to allow a user to read from a heapdump file
- extra unhandled error logging
- customisation of header options as our auth proxy adds lots of openid headers which exceed vertx defaults

Also, I added a build parameter to Jifa.js
- Setting VUE_APP_JIFA_FILE_MGMT=false will hide the file management features in the UI (release/upload/etc) as we have a separate UI for this

I think this is a simple way to approach the problem & hope for your thoughts!!

_______________________________________________
jifa-dev mailing list
jifa-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jifa-dev

Back to the top