Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jgit-dev] File.toPath() usages may result in InvalidPathException

I just wanted to point out that jgit has several unsafe usages of File.toPath() which may (and actually do) throw nasty InvalidPathExceptions. The vast majority of bug reports are caused by FileUtils.lastModified and are looking like:

	at sun.nio.fs.UnixPath.encode(
	at sun.nio.fs.UnixPath.<init>(
	at sun.nio.fs.UnixFileSystem.getPath(
	at org.eclipse.jgit.util.FileUtils.lastModified(
	at org.eclipse.jgit.util.FS.lastModified(
at at

I think it would be reasonable to catch the InvalidPathException and convert into an IOException. I can provide a patch, if of interest.


Back to the top