Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] A cycle was detected

On Thu, Apr 18, 2013 at 1:39 AM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
On Thu, Apr 18, 2013 at 1:08 AM, Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote:

I think it is this:

- We use the same package names in both implementation and test projects
- We use package imports.

Therefore Eclipse does not know what project other projects depend on
and guesses wrong, e.g. it decides that e.g. the project org.eclipse.jgit.ant
needs the package org.eclipse.jgit.lib, which it finds in the project org.eclipse.jgit.test
which in turn needs the org.eclipse.jgit project.

could we change the test bundles to become fragments like we do in egit ?
Since fragments extend their host bundle this could help PDE to not go into cycles.

I think I found the problem: org.eclipse.jgit.test did export package org.eclipse.jgit.lib
which it shouldn't since this package is in bundle org.eclipse.jgit. This export made this
package a split package which most probably caused the observed cycles.

Pushed the fix for review https://git.eclipse.org/r/#/c/12039/

--
MatthiasĀ 

Back to the top