|[jgit-dev] Fwd: Any chance for some feeback on those 2 patches?|
Hi Tomasz, Hi Matthias|
Thanks for pointing me to the failing tests which unveiled an overload I had missed. I fixed it.
The only failing case is now SmartClientSmartServerTest#testListRemote_BadName which also fails in master without my patch.
I hope this now fullfills your expectations and it would be absolutely awesome if we could get this in before the next release.
Thanks for all your efforts!
-------- Original Message --------
In order to be able to display server message while we're pushing (like screencasted here: https://bugs.eclipse.org/bugs/attachment.cgi?id=225770), I did 2 patches for egit and jgit and pushed those to gerrit:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398387 -> https://git.eclipse.org/r/#/c/9730/
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398404 -> https://git.eclipse.org/r/#/c/9732/
I double checked the test failures displayed in jenkins (all in SmartClientSmartServerTest) and I'm pretty sure that they're not related to my patches. They fail when the BasePackFetchConnection writes to the connection outputstream (not my outpustream). The connection's using a DisabledOutputStream which throws "java.lang.IllegalStateException: Writing not permitted".
I'd highly appreciate if we could have this included in Kepler so it would be great if we could have the discussions going on and the patches indluded. Any chance for some feedback please?
Back to the top