|Re: [jgit-dev] plexus-archiver as optional "jgit archive" dependency|
On Mon, Dec 3, 2012 at 10:55 AM, Jonathan Nieder <jrn@xxxxxxxxxx> wrote: > Chris Aniszczyk wrote: > >> plexus archiver 2.2 is available: >> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=6821 >> >> commons compress 1.3 is available: >> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=6258 >> >> I would prefer whatever is the lighter weight dependency, which is probably >> commons compress (which supports external file attributes). > > I've put up an RFC using commons-compress: > > https://git.eclipse.org/r/#/c/9007/ > > For simplicity this is as an actual dependency rather than an optional > one. I haven't made my mind up about whether that's good. I was > tempted to make archive formats for "jgit archive" into a kind of > plugins and just have one format (e.g., tar) built-in as a demo, but > there's also something to be said for the intuitiveness of letting > commons-compress take care of it all. Being able to create an archive isn't necessarily a critical feature of JGit. I would prefer if this was broken into its own library/plugin so that consumers have a choice of whether or not they want to include commons-compress in their product. If they do, they can include our archive support JAR and have it work. If they don't, it doesn't. The pgm package is already once such case, pgm isn't normally bundled for a consumer and therefore its OK to depend on it here.
Back to the top