[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Breaking the Tag API (was[egit-dev] release 1.2 ahead)

Robin Rosenberg skrev 2011-12-03 12.12:
Matthias Sohn skrev 2011-12-03 01.20:
2011/12/2 Robin Rosenberg <robin.rosenberg@xxxxxxxxxx <mailto:robin.rosenberg@xxxxxxxxxx>>
[...]

Here is an API bug.

https://bugs.eclipse.org/bugs/__show_bug.cgi?id=360650 <https://bugs.eclipse.org/bugs/show_bug.cgi?id=360650>

That's easy to fix if we don't consider that fixing it would
involve breaking the API. Would that be ok? The API iself is part of
the bug here.


I think we should fix this as currently this is a broken API

Breaking and fixing API here:

http://egit.eclipse.org/r/#change,4726

We have some disagreement about this one. My opinion is that we should not introduce a new object for tags, but rather treat them as branches for which we do not have special objects either.

Both can and should be handled as Ref objects.

If we cannot agree, then we'd have to break the API post-1.2 and
since breaking API's are a bad thing and 2.0 is not on the horizon
we should break it as soon as possible.

An alternative to breaking the API would be to introduce a new API.
Name: TagCommand2? That would follow the pattern used elsewhere when
it has been found out that an API is not sufficient.

In any case we'd have to agree on the return type.

http://egit.eclipse.org/r/#change,4727 (demo)


-- robin