Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] submitting jgit proposals (too) fast

On 11.03.11 17:46, Christian Halstrick wrote:

> Are there any best practices of other projects which solve this? Some
> kind of minimum time a non-trivial proposals should stay in review
> (or: before I submit a proposal where there is already another
> reviewer I wait at lest 24hours after the last patchset). Or a rule
> that authors should vote (-2) on their proposals if they are not sure
> whether they are ready for submit.
> 
> What's your opinion about that?

My _personal_ preferences are:

- vote 0/-1 for not-ready-to-submit (AKA WIP) own proposals, +1 otherwise;
- never submit a non-urgent changes without getting another committer's
opinion.

-- 
Mykola


Back to the top