Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Re: Gerrit offline for JGit rewrite

onsdagen den 10 mars 2010 16.28.31 skrev  Shawn O. Pearce:
> "Zivkov, Sasa" <sasa.zivkov@xxxxxxx> wrote:
> > "Shawn O. Pearce" <spearce@xxxxxxxxxxx> wrote:
> > > Oh.  Something else...
> > >
> > > When I insert the rewrite, inline comments are going to be screwed up.
> > >  Inline comments are recorded by line numbers.  Most files have gained
> > > 5+ lines in their file header.  Without knowing the delta of the
> > > header for each file in every commit, we can't adjust the inline
> > > comment information in the review database.
> >
> > Inline comments on my last pushed change (#315) have disappeared.
> > In the patch set overview it is correctly reported how many inline
> > comments there are for each file. However, If I open any of the files the
> > inline comments are not shown.
> Frell.
> 82 inline comments in 13 changes had their line numbers set to 0 when
> I attempted to merge in the delta of the header impact.  Yesterday I
> also pulled the brillant move of wiping the backup file.  Arrrrgh.
> I've moved them all to line number 1, so they appear in the file, but
> they are at the wrong spot.  Sorry.  Without digging through email
> archives and manually matching up these 82 comments back to their
> original line numbers, there's no way to reposition these accurately.

I wouldn't go that far. It would be possible to automatically detect the
repositioning since you have the file before and after and the diff would
tell us what moved and how much. It's not worth it in general, but then
with Gerrit at Eclipse, it might be useful as a standard feature. I think your
compromise is ok this time.

-- robin

Back to the top