[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jetty-dev] URLs with IDN domains in jetty-client doesn't work
|
Hi,
On Tue, Dec 13, 2016 at 2:59 PM, Konstantin Gribov <grossws@xxxxxxxxx> wrote:
> Hi, folks.
>
> I've found that jetty-client (9.3.11 and 9.3.14 at least) fails to work with
> international domain names if they are not encoded to punycode.
>
> The code like `HttpClient.newRequest("http://кто.рф";).send()` will fail with
> NPE thrown from `send` invocation because `newRequest(String)` use
> `j.n.URI.create(String)` which returns URI with `null` in its host.
>
> I think, it would be better to add some note to `newRequest`'s javadoc about
> such behavior and create more meaningfull exception which should be thrown
> from `newRequest` and not from `send` which can be called several hundred
> lines later.
>
> Do you accept pull requests at github, I forgot?
Yes we do accept PR at GitHub, but make sure you follow the
contribution guidelines here:
http://www.eclipse.org/jetty/documentation/9.3.x/contributing-patches.html
The patch would be to throw a better exception or to allow
international host names ?
--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
