I thought the main
idea of the API Tools check in Gerrit is to catch things that the contributor
does not see in his workspace, e.g. because API Tools is not set up (correctly).
My problem is that it fails on warning but the warning is not shown by
the job, as opposed to "normal" warnings.
This is a problem with jenkins warning plugin not properly gathering all warnings in it's report. Nothing we can fix but feel free to report the issue to them :).
We will enable failOnWarning only when THERE ARE NO EXISTING WARNINGS BREAKING THE BUILD. That way it will prevent introducing new warnings in the codebase.
Regarding not being visible on the job result page but rather in the log - same with compile issues - one has to read the log to see them.
Dani
From:
Aleksandar
Kurtakov <akurtako@xxxxxxxxxx>
To:
"Eclipse
JDT general developers list." <jdt-dev@xxxxxxxxxxx>
Date:
25.09.2019
18:12
Subject:
[EXTERNAL]
Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent
by: jdt-dev-bounces@xxxxxxxxxxx
On Wed, Sep 25, 2019 at 6:58 PM Daniel
Megert <daniel_megert@xxxxxxxxxx>
wrote:
> The
warnings are also visible on the platform downloads page.
Yes, but how does this help the contributor if there's no warning there
but the Gerrit change fails?
The contributor will see the warning
in his code and right after that the build will stop.
Dani
From: Roland
Grunberg <rgrunber@xxxxxxxxxx>
To: "Eclipse
JDT general developers list." <jdt-dev@xxxxxxxxxxx>
Date: 25.09.2019
17:55
Subject: [EXTERNAL]
Re: [jdt-dev] Add maven.compiler.failOnWarning to gerrit jobs
Sent by: jdt-dev-bounces@xxxxxxxxxxx
On Tue, Sep 24, 2019 at 6:03 PM Daniel Megert <daniel_megert@xxxxxxxxxx>
wrote:
>
> Shouldn't this appear on he main status page? No one is looking
at the logs. Why is it not there?
The warnings are also visible on the platform downloads page. I could add
-Dmaven.compiler.failOnWarning for eclipse.jdt.ui once the JIRO migration
is stabilized, since there are no existing warnings.
I've also opened up https://bugs.eclipse.org/bugs/show_bug.cgi?id=551469
to address some of the warnings in jdt.debug.
--
Roland Grunberg
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
--
Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jdt-dev
