We don’t need the deletion of geometry and forms in the history anyway…
From: january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx]
On Behalf Of Jonah Graham
Sent: 20 January 2017 09:42
To: january developer discussions
Subject: Re: [january-dev] Newbie using January
Hi all,
the problem with a revert is that it loses history, please do a merge commit to restore the files.
(BTW I don't know what the revert PR button does, but I assume it is a "simple" revert.)
On 20 Jan 2017 09:26, <Peter.Chang@xxxxxxxxxxxxx> wrote:
I will hit the big red button then ;-)
Peter
From:
january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx]
On Behalf Of Matthew Gerring
Sent: 19 January 2017 19:17
To: january developer discussions <january-dev@xxxxxxxxxxx>
Subject: Re: [january-dev] Newbie using January
There is a revert button on the pr. Maybe we should press that and continue the debate? No hard feelings from me :-)
Whatever you want to do is fine with us. We have our pull request waiting with all the major points from Issue 26 addressed. But we’re good either way, just waiting on a decision
from you and Jonah.
It seems that we are at an impasse. The additional dependencies
from the geometry and form plugins are causing concern to potential January users who are just interested in the nD datasets as advertised by our marketing -- no-one expects the other parts!
Can I propose that we modify the releng so that dataset-only
build is possible?
Yea sure I can do that. I'll take some time out this morning to look at it.
Alex McCaskey can probably give it a look. I'm traveling today.
(accidentally removed january-dev from last reply, Robert can you
re-reply on the mailing list too please :-)
Hi Robert,
Someone who is familiar with the code needs to review it. Who would
you recommend? Jay has started on it.
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
On 19 January 2017 at 13:34, Smith, Robert W. <smithrw@xxxxxxxx> wrote:
> Jonah,
>
> Pull Request #28 fixes bug #25 and most of #26, leaving only the updates to the README file and the addition of geometry and form examples, which are obviously non-essential. I believe this addresses most of Torkild's original concerns about these packages,
though I'll be happy to also rename the *.xtext bundles to *.dsl if that would be clearer. I notice that multiple other pull requests have been merged in since two weeks ago when I submitted it, and was wondering what the was left to be done to allow it to
be accepted.
>
> Robert
> ________________________________________
> From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
> Sent: Thursday, January 19, 2017 7:23 AM
> To: january developer discussions
> Cc: Smith, Robert W.
> Subject: Re: [january-dev] Newbie using January
>
> Hi Jay,
>
> I think we need for now to get to a working January and then build up.
> I am glad to hear that Robert is close, and when it is ready it should
> be submitted. But at the moment the January project is suffering
> because of these outstanding issues.
>
> I don't believe anyone is talking about re-hashing old issues. simply
> getting January to the point we have all agreed on. At the moment the
> code in January does not meet that requirement so we keep
> meta-rehashing.
>
> Thanks,
> Jonah
>
> ~~~
> Jonah Graham
> Kichwa Coders Ltd.
> www.kichwacoders.com
>
>
> On 19 January 2017 at 12:17, Jay Jay Billings <jayjaybillings@xxxxxxxxx> wrote:
>> Everyone,
>>
>> Even though there were very good reasons to include the form and geometry
>> bundles from the beginning, I regret that everyone keeps forgetting or
>> ignoring those reasons and that these bundles keep causing trouble for the
>> community. Robert Smith did, in fact, just switch ICE and EAVP over to use
>> January, but he is still testing in a branch and hasn't merged those changes
>> yet.
>>
>> I don't mind continuing to fix the form and geometry bundles to keep them in
>> January because that only makes them better and helps the project, in my
>> opinion. However, at this point I an not keen on continuing to rehash old
>> arguments about why we wanted a general purpose data structures project in
>> Science because I think it is unhealthy. I would much rather let the January
>> Project Leads and committers make the decision on where the project should
>> go.
>>
>> Jonah and Peter, I leave it to you at this point to either accept Matt's PR,
>> removing the parts of January that ICE and EAVP currently need, or simply
>> closing it and asking Robert and I to clean up our mess, including
>> addressing issues described in the second and fourth paragraph of Torkild's
>> email. I'll happily support either path.
>>
>> Jay
>>
>> On Thu, Jan 19, 2017 at 5:48 AM, <Matt.Gerring@xxxxxxxxxxxxx> wrote:
>>>
>>> Thanks! :)
>>>
>>> -----Original Message-----
>>> From: january-dev-bounces@xxxxxxxxxxx
>>> [mailto:january-dev-bounces@xxxxxxxxxxx] On Behalf Of Jonah Graham
>>> Sent: 19 January 2017 10:46
>>> To: january developer discussions
>>> Subject: Re: [january-dev] Newbie using January
>>>
>>> > Later I propose to put a build hook on the pull request. This is done
>>> > by asking for admin from eclipse webmaster and adding the hook on
>>> > github. The build appears to be maven, so there are various options
>>> > for that in github J
>>>
>>> The build hook for travis is already enabled, just needs the travis file
>>> contributing AFAIK.
>>> _______________________________________________
>>> january-dev mailing list
>>> january-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit https://dev.eclipse.org/mailman/listinfo/january-dev
>>>
>>> --
>>> This e-mail and any attachments may contain confidential, copyright and or
>>> privileged material, and are for the use of the intended addressee only. If
>>> you are not the intended addressee or an authorised recipient of the
>>> addressee please notify us of receipt by returning the e-mail and do not
>>> use, copy, retain, distribute or disclose the information in or attached to
>>> the e-mail.
>>> Any opinions expressed within this e-mail are those of the individual and
>>> not necessarily of Diamond Light Source Ltd.
>>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
>>> attachments are free from viruses and we cannot accept liability for any
>>> damage which you may sustain as a result of software viruses which may be
>>> transmitted in or with the message.
>>> Diamond Light Source Limited (company no. 4375679). Registered in England
>>> and Wales with its registered office at Diamond House, Harwell Science and
>>> Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
>>>
>>> _______________________________________________
>>> january-dev mailing list
>>> january-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/january-dev
>>
>>
>>
>>
>> --
>> Jay Jay Billings
>> Oak Ridge National Laboratory
>> Twitter Handle: @jayjaybillings
>>
>> _______________________________________________
>> january-dev mailing list
>> january-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from
>> this list, visit
>> https://dev.eclipse.org/mailman/listinfo/january-dev
>>
>
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an
authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt
by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
|
