Re: [january-dev] January Refactoring

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi Peter,

I was wondering if there is some code that we could use as the initial
contribution at the moment. As Jay mentioned we don't have to have to
have compiling code. I think I just would want code extracted from a
commit id that will not disappear (e.g. not be rebased away). Then we
can start the CQ process?

Thoughts and/or ETAs?

Thanks!
Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 29 June 2016 at 09:26,  <Peter.Chang@xxxxxxxxxxxxx> wrote:
> Hi Jonah,
>
> I'm slowly progressing through my set of changes. They are mainly code tidy ups so far:
>
> 1. Exception cleanup: Dataset, Metadata exceptions thrown by ILazyDataset, ILWD,
> IMetadataProvider, IRemoteDataset, ILazyLoader, ILazySaver, IMetaLoader, IMetadata
>
> 2. Remove IErrorDataset: move methods to ILD and ID
>
> 3. Rename method elementClass to getElementClass, realView to getRealView,
> imagView to getImaginaryView, getDType, etc
>
> Now onto these:
>
> 4. Replace use of dataset constructors with factory methods
>
> 5. Remove legacy factory methods
>
> 6. Refactor entire namespace
>
> At the moment, the changes are on local branches but the plan is to push them all to either Gerrit (off its master) or remote branches (called january-refactor) that Matthew Webber will set up Jenkins jobs for integration testing.
>
> Peter
>
> -----Original Message-----
> From: Jonah Graham [mailto:jonah@xxxxxxxxxxxxxxxx]
> Sent: 29 June 2016 08:55
> To: Chang, Peter (DLSLtd,RAL,LSCI) <Peter.Chang@xxxxxxxxxxxxx>
> Cc: Tracy Miranda <tracy@xxxxxxxxxxxxxxxx>
> Subject: Re: January Refactoring
>
> Hi Peter,
>
> I am all done my governor school stuff for this week, so I am around today and tomorrow.
>
> Have you had much luck so far?
>
> Jonah
> ~~~
> Jonah Graham
> Kichwa Coders Ltd.
> www.kichwacoders.com
>
>
> On 27 June 2016 at 10:04,  <Peter.Chang@xxxxxxxxxxxxx> wrote:
>> Hi Tracy,
>>
>>
>>
>> Yes, that’s fine. Call me on 01235 778092 after 1030 (got a meeting now).
>>
>>
>>
>> Regards,
>>
>> Peter
>>
>>
>>
>>
>>
>> From: Tracy Miranda [mailto:tracy@xxxxxxxxxxxxxxxx]
>> Sent: 27 June 2016 09:30
>> To: Chang, Peter (DLSLtd,RAL,LSCI) <Peter.Chang@xxxxxxxxxxxxx>
>> Cc: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
>> Subject: January Refactoring
>>
>>
>>
>> Hi Peter,
>>
>>
>>
>> Hope you had a refreshing break. We're all set to help work on the
>> January refactor though Jonah is unable to make it up to Diamond in
>> person today or tomorrow. Instead, let's proceed virtually.
>>
>>
>>
>> Would you be available for a call/skype sometime this morning, say 11am ?
>>
>>
>>
>> Regards,
>>
>> Tracy
>>
>>
>>
>> --
>>
>> This e-mail and any attachments may contain confidential, copyright
>> and or privileged material, and are for the use of the intended
>> addressee only. If you are not the intended addressee or an authorised
>> recipient of the addressee please notify us of receipt by returning
>> the e-mail and do not use, copy, retain, distribute or disclose the
>> information in or attached to the e-mail.
>> Any opinions expressed within this e-mail are those of the individual
>> and not necessarily of Diamond Light Source Ltd.
>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
>> attachments are free from viruses and we cannot accept liability for
>> any damage which you may sustain as a result of software viruses which
>> may be transmitted in or with the message.
>> Diamond Light Source Limited (company no. 4375679). Registered in
>> England and Wales with its registered office at Diamond House, Harwell
>> Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United
>> Kingdom
>>
>
> --
> This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
> Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
> Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
> Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom