[
Date Prev ][
Date Next ][
Thread Prev ][
Thread Next ][
Date Index ][
Thread Index ]
[
List Home ]
Re: [jakartaee-tck-dev] WIP TCK Servlet with Arquillian
On 3/24/22 1:06 AM, Olivier Lamy wrote:
Hi,
On 3/16/22 1:59 AM, Olivier Lamy wrote:
Hi
I finally rolled up my sleeves and made some
changes for the TCK servlet to be able to run using
Arquillian.
This is an early stage but it works (for only a
limited number of tests at this time).
To be honest right now, there are only two
classes with 19 tests :) (but I'm currently looking
at adding few more)
Just search the class
with @ExtendWith(ArquillianExtension.class)
It requires some local build if you want to test
that.
https://github.com/olamy/jakartaee-tck/tree/servlet-module-atleast
is looking good so far, nice start!
I made some more progress and finally found a way to
honour the javadoc tag used in the code (otherwise it's
running too many tests)
The first step is a Maven plugin parsing java sources to
generate a file (/META-INF/tck-tests.txt) containing all
class#method
Then I created a junit TestEngine which read those files
to configure the tests to run.
The idea is to have a Maven projects having differents
TCKs such servlet, jsp, websocket and run tests according to
those files.
+1
Currently as of now with Jetty Arquillian there are only
1319 tests running.
The TCK should have 1685 tests which is what is generated
by the Maven plugin parsing the sources.
I have figured out some issues to fix as some tests do
not start as the archive cannot be deployed.
The reasons are: missing a login service (some tests have
some <login-config>), https (default arquillian
deploys only in http),...
so still some work to do but made some progress.
Please have a look and let me know.
https://github.com/jakartaee/rest might of dealt with that in
their TCK.
https://github.com/jakartaee/rest/blob/master/jaxrs-tck/src/main/resources/ee/jakarta/tck/ws/rs/ee/rs/core/securitycontext/basic/web.xml.template#L65
has a login-config and
https://github.com/jakartaee/rest/blob/master/jaxrs-tck/src/main/resources/ee/jakarta/tck/ws/rs/ee/rs/core/securitycontext/basic/web.xml.template#L65
does as well.
TCK changes are in my fork
I haven;t changed everything I'd like to change
(such as simplification of some parts, using jdk
httpclient, a lot of cleanup as it's now jdk11
level, using more test asserts etc...)
I have left some class dependencies in the
libutil module.
Ideally I'd like to remove this as well to have
only a single module. but I don;t really very strong
opinion.
Please let me know what do you think (and
remember it's only a start to make part of the
current code working with Arquillian and this can
(need to) be improved a lot!)
cheers
--
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
--