Hi Jared,
I see, I think I misinterpreted: I did think that we were changing the minimum version but if we’re just expanding the range then we’re all good.
It still leaves the question of the versioning scheme (whether this should be a 3.0.1 or a 3.1.0), but I think that’s a minor concern.
Cheers, Abraham
— Abraham Marin-Perez
🖥️ https://www.cosotateam.com/ 💼 https://www.linkedin.com/in/abraham-marin-perez/ 🐦 https://twitter.com/AbrahamMarin
On Jul 18, 2024, at 11:11 AM, Jared Anderson <jhanders@xxxxxxxxxx> wrote:
I guess I need to understand what you mean by uplifting. If you are saying we are changing the minimum level of _expression_ Language, then yes that would be concerning, but that is not the case here. If you are referring to us expanding the range for _expression_ Language to include BOTH 5.0 and 6.0, then no matter which version they use, it will be resolved from an OSGi perspective. The compatibility concern would be if the tags API was using deprecated function from 5.0 that was removed in 6.0. If it was doing that the code would need to be updated to remove references to those deprecated methods / classes from 5.0.
Jared Anderson
-----Original Message----- Subject: Re: [ jakarta.ee-spec] [jstl-dev] Fwd: [EXTERNAL] Re: Could one of the Specification Committee members please promote the following (Jakarta EE 10) TCK service releases... Date: 07/18/2024 12:57:19 PM
Hi there,
Not to be unnecessarily picky but a 3.0.1 (or 3.0.2) would signify a bug fix according to semantic versioning, while I don’t think this can be called a bug fix. Also, can we guarantee that uplifting the version of EL will be backwards compatible?
Cheers, Abraham
On Jul 18, 2024, at 7:01 AM, Richard Opalka via jakarta.ee-spec <jakarta.ee-spec@xxxxxxxxxxx> wrote:
Hello, I see this is the newer thread than the one I wrote to few minutes ago.
When can we expect new 3.0.2 tags implementation release to be available?
Richard
Good questions Paul! This is why I drove to get this information properly documented in a wiki. Once you find out, please have them documented in the github repo so that others can follow the same instructions. Thanks Emily
Hi Arjan, Thanks, I’d like to ask a few questions about those jobs. Currently the Tags 3.0 code lives in this branch: https://github.com/jakartaee/tags/tree/3.x, this branch includes the API and IMPL. Is there another job to release the IMPL? To execute this job: https://ci.eclipse.org/jstl/job/1_jstl-api-build-and-stage/I would: 1. Click “Build with Parameters” 2. Properties to fill in: b. BRANCH -> Currently the default is “master” so I would need to change that to “3.x” 3. Do I need to check any of the other options? DRY_RUN, OVERWRITE, LIST_FIRST, DROP_FIRST, DROP_ID? Thanks, Paul Nicolucci
Hi,
The release should be easy. It's running this job:
That one will build the API jar and stages it. If it's fine in staging, you can release it to central using:
For that you need the staging ID, which if you look carefully can be fetched from the logs of the first job.
Hope this helps!
Kind regards, Arjan Tijms
Hi,
The release needs to be done and I talked with Arjan about doing this and he said he could help.
Regards,
Paul Nicolucci
Forward to Tags ml as fyi...
That seems logical to me but: - Who would be responsible for making this change?
- What other related work must be done?
Thanks, Ed Would it be sufficient to create a 3.0.1 service release for tags to expand the range for the OSGi Import for _expression_ language and pages? Import-Package: jakarta.el;version="[5.0,6)",jakarta.servlet;version="[6.0,7)",jakarta.servlet.http;version="[6.0,7)",jakarta.servlet.jsp;version="[3.1,4)",jakarta.servlet.jsp.jstl.core,jakarta.servlet.jsp.tagext;version="[3.1,4)",javax.xml.parsers,org.xml.sax,org.xml.sax.helpers Import-Package: jakarta.el;version="[5.0,7)",jakarta.servlet;version="[6.0,7)",jakarta.servlet.http;version="[6.0,7)",jakarta.servlet.jsp;version="[3.1,5)",jakarta.servlet.jsp.jstl.core,jakarta.servlet.jsp.tagext;version="[3.1,5)",javax.xml.parsers,org.xml.sax,org.xml.sax.helpers WebSphere Jakarta delivery lead -----Original Message----- Subject: Re: [jakarta.ee-spec] [EXTERNAL] Could one of the Specification Committee members please promote the following (Jakarta EE 10) TCK service releases... Date: 07/12/2024 05:22:50 PM Also related to tags is JEA-242. I have not followed this closely enough to be able to easily tell if the following is done. Can someone confirm if it is? From the above issue: Players Pages 4. 0 depends on EL 6 M1 Tags 3. 0 (JSTL) depends on Also related to tags is JEA-242. I have not followed this closely enough to be able to easily tell if the following is done. Can someone confirm if it is? From the above issue: - Pages 4.0 depends on EL 6 M1
- Tags 3.0 (JSTL) depends on EL 5 M1
- We cannot have this mismatch due to OSGi.
- Do a Tags 3.1 which increases the dependency on EL to be 6 M1.
- This requires specification committee action to approve the release, even if the only thing changing is incrementing the EL dependency level.
- Timeframe: target this to Milestone 2.
Bottom line: @arjan.tijms will take the necessary actions to push this through for M1 and we will do the process work to do the right thing for M2. Thanks, Ed _______________________________________________ jakarta.ee-spec mailing list _______________________________________________ jakarta.ee-spec mailing list jakarta.ee-spec@xxxxxxxxxxxTo unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec_______________________________________________ jstl-dev mailing list
_______________________________________________ jstl-dev mailing list
_______________________________________________ jakarta.ee-spec mailing list
--
_______________________________________________ jakarta.ee-spec mailing list
_______________________________________________ jakarta.ee-spec mailing list jakarta.ee-spec@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec
_______________________________________________
|