Re: [jakarta.ee-community] Pull Request for jakartaee-examples

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi,

It starts to look better, thanks again. It's a slow process, I know, but bear with us ;)

For the project as a whole, all samples are intended to be quite ordered/categorised. So the example from Nishant fit in quite well -> JSP -> Lifecycle methods. Meaning it demonstrates a single concept.

With the "learning servlet" it's less clear from its name. In the bigger picture of the project, with dozens of Servlet examples, what does a "learning Servlet" practically mean? All examples are to learn from, and to demonstrate something is working on a specific Servlet implementation (this last part should not be forgotten).

In this case, it's a Servlet to which some simple requests are done via an .html file, where the tests use that .html file as well. Maybe "basicRequests" or "simpleRequests" would be a better name? 

I know in this case the name is hard. Your sample is quite like this one: https://github.com/javaee-samples/javaee7-samples/tree/master/servlet/simple-servlet 

Where maybe "simple servlet" didn't fully describe the purpose of the example either, but I think it's still a little bit clearer than "learning servlet".

Also, there's a lot of comments about how basic things work that are not necessarily related to what the sample is demonstrating. We could perhaps say that this is the initial sample everyone should look at, so that one has all those comments, but then we'd better put that in the readme.md. Otherwise it looks quite out of place if say 100 samples only have comments about what they are demonstrating, and then one random sample has comments explaining Maven, Java etc itself

TLDR; consider a better name for the "learning servlet", put in the readme.md that this sample is the initial one people could look at.

Hope this helps ;)

Kind regards,

Arjan Tijms

On Sun, May 3, 2020 at 1:24 PM Kenneth Fogel <kfogel@xxxxxxxxxxxxxxxxxxx> wrote:

Hi,

I believe I have addressed all the issues that arose from my first pull request and so a new one in waiting. If there is anything else you’d like me to do please let me know. And if you feel it’s not appropriate that’s fine too.

Ken

---

From: jakarta.ee-community-bounces@xxxxxxxxxxx <jakarta.ee-community-bounces@xxxxxxxxxxx> on behalf of omniprof@xxxxxxxxx <omniprof@xxxxxxxxx>
Sent: Wednesday, April 29, 2020 3:47:10 PM
To: 'Jakarta EE community discussions' <jakarta.ee-community@xxxxxxxxxxx>
Subject: [jakarta.ee-community] Pull Request for jakartaee-examples

 

Hi,

 

I have just submitted a pull request, my first ever, for jakartaee-examples. It consists of The Learning Servlet along with a minor error correction to the parent pom file. As requested it is in the same style as all other individual projects and does not use any external libraries. There is a simple test that deploys the web site and then clicks on a button to execute the servlet.

 

Feel free to make any suggestions or criticisms. I hope to submit more especially as I have figured out how to do it, finally.

 

Ken Fogel

 

 

_______________________________________________
jakarta.ee-community mailing list
jakarta.ee-community@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-community