Re: [glassfish-dev] Time to rename the ORB packages?

[Russell Gold <russell.gold@xxxxxxxxxx>]

On Mar 29, 2020, at 6:34 AM, Lukas Jungmann <lukas.jungmann@xxxxxxxxxx> wrote:

On 3/29/20 3:18 AM, Russell Gold wrote:

I’ve spoken with a worker at Jetbrains. It seems that excluding com.sun.* packages from code coverage is something they’ve done as an optimization, since almost all such code is in the JDK.

Do they offer an option to turn this optimization off for people who work on projects having to work with these packages? Or do they just take it for granted that (Open)JDK people are not using Jetbrains tooling at least within context of code coverage? I found nothing related to this at https://urldefense.com/v3/__https://youtrack.jetbrains.com/issues__;!!GqivPVa7Brio!JZlOH9gFM5oF_p2xTS00vHINX0cgIOusNDvv8n0PZeGzQ64K6WM5Ef8ZVBbGCxyeLA$ 

Here’s my bug report, with their responses, including:

The optimisation was always there and it's not possible to disable it. I can provide vm option to skip those optimisations but I guess they would be on by default anyway.

Also note that there are other projects using com.sun.* packages under ee4j/jakartaee space these days, so should one of them move, others should at least consider doing the same.

I think we probably should. I am looking to figure out ways to make this as painless as possible. Given the wholesale move from javax.* to jakarta.* and the disruption expected, this might be the best time.

thanks,
--lukas

Most of the orb classes would not be used externally, but I would like to be able to verify this. Is there a way to search Maven central to see what projects depend on a particular project? The data should be there. >

On Mar 28, 2020, at 3:18 PM, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:

In general, we're not renaming implementation packages.

It sounds like a bug, or configuration error, that IntelliJ won't handle
these packages.  There are com.sun packages in other EE4J components.
For example, I don't plan to rename the com.sun classed in Jakarta Mail
because users have been using those classes for some time.  While it
may be no worse than renaming javax, it's just another cut.

In your case, if the IntelliJ problem is serious for you and can't be
fixed, then you can take the risk and rename the packages.  Just be careful
not to make things worse.


Russell Gold wrote on 3/27/20 8:58 AM:

The ORB classes are still located under com.sun.corba.ee.* Aside from lack of consistency, this has now turned out to be a maintenance problem, as my IDE, Intellij IDEA specifically excludes com.sun.* packages from code coverage results, since that hierarchy is generally used for the JDK. So the question is timing. I’m thinking that the time has come to do the rename. If users of the ORB are doing things correctly, only the main ORB and ORB singleton class names should be pertinent - and I can make those extend the new class names.

Thoughts?

- Russ
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!KZY4amxSORc_tcorxmDPoScclaCEmMRnb576xjAqy1Mrs2LZ8rcvwBSVh7ingFHgOQ$

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!MKL7Uk5qHrti-N8gXHfrOy98hjlrvfGlfht5G8h-r8lCD3wO-MEy25yDXmu32A7JKhA$

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!JZlOH9gFM5oF_p2xTS00vHINX0cgIOusNDvv8n0PZeGzQ64K6WM5Ef8ZVBZwYcvYqQ$