Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [escet-dev] Contributing to ESCET
  • From: Dennis Hendriks <dh_tue@xxxxxxxxxxx>
  • Date: Sat, 10 Apr 2021 14:30:04 +0000
  • Accept-language: nl-NL, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RV+8654oAT14xSU6wGPznSvk5OsuOhcA2hvZtsmHwbI=; b=c2JGy57ZXD9wh6zmh4N2PT+oeTfvpA/1aLAAFrHcfOs0+9ETpS1HlzRg0MutM/JiYvwlECmxCu+K0+Jor0v/ygUevU4gcLSDYTejKIszwq6h5tfpaYObFazNXU9beTX96K7W4WeZ/NoJE/Bft4OZY2FvrpzTUClGtyEqRExHzo+gv4cjQ7z1ksmISV2aRh0cf7tyt5vpOD1jEmi5lc5x5PuF33tYLEUiqraD+PunBqVqcur/d89LBUuzbQ+hikMZa7UTnfRFl8hdwlXl6XPli3ygkocgkKtRypbxEKL+NC8Bmj+Uh2XBb3JhNfNJBi03okNZO0f5djLycLUsO/JU8A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QypQ66h4draJHX5uh28sjc9YkZW1czCvn1E0W2PQOBAtsArjoN8K23XUvzMYI12yKf8X4z7BPcFnYiwI2HbdWXk4WuSoUuzXkT9c6mS5wPD6KvrSBnjdaoX+22btEKze5ZzL1VjqVYeBc1hOifc8J4/cW/2q6WPjTjQk5/q9e5MhZ+l9gSic6nlJS202JO95lxoxGc/Iq7F+nhkzBbxaoULo78Sb6Q2VSCsjimqjdVrCyTGgTKyFWCB7y7WsSFXl6EIM1fdBO70jJls/put2bBrE9AZzjE6JASGVzVptzaRmj9cArtkacSAzm4M2jAoG70A0kiwbAZsaNShmHdgsxw==
  • Delivered-to: escet-dev@xxxxxxxxxxx
  • List-archive: <https://dev.eclipse.org/mailman/private/escet-dev/>
  • List-help: <mailto:escet-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://dev.eclipse.org/mailman/listinfo/escet-dev>, <mailto:escet-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://dev.eclipse.org/mailman/options/escet-dev>, <mailto:escet-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHXLT7bV1MDUnW3+kaxByno5pV8UaqtjGUWgAARLICAADJVMA==
  • Thread-topic: [escet-dev] Contributing to ESCET
Hi Ferdie,

> The only suggestion I have is to include what you expect in the "signed-off-by" field, it is not mentioned in the handbook you link, I had to google it. 

This is actually no longer required. See https://gitlab.eclipse.org/eclipse/escet/escet/-/issues/50

> For the issues on GitLab. I'm not sure if it is intended, but I was unable to add labels [...]

I don't know. I assume it is an access rights issue. We don't have access to change the configuration currently. This may change in the future, see https://gitlab.eclipse.org/eclipsefdn/gitlab/-/issues/17. For now, we can just add the labels for you.

> [...] or assign myself to the issue. 

It seems we can only assign issues to committers. Maybe we can change that as well later. For now, just indicate in the comments that you're working on it.

Dennis

Van: escet-dev <escet-dev-bounces@xxxxxxxxxxx> namens Ferdie Reijnen <ferdie.reijnen@xxxxxxxxx>
Verzonden: zaterdag 10 april 2021 13:24
Aan: escet developer discussions <escet-dev@xxxxxxxxxxx>
Onderwerp: Re: [escet-dev] Contributing to ESCET
 
Hi Dennis,

Thanks for your quick response and for improving my contribution!

The guidelines are clear and I could easily follow them. I was not familiar with forking and then merging from the forked repository, but it was explained well. The only suggestion I have is to include what you expect in the "signed-off-by" field, it is not mentioned in the handbook you link, I had to google it. 

For the issues on GitLab. I'm not sure if it is intended, but I was unable to add labels or assign myself to the issue. 

Kind regards,
Ferdie

On Sat, 10 Apr 2021 at 12:31, Dennis Hendriks <dh_tue@xxxxxxxxxxx> wrote:
Hi Ferdie,

Thanks for trying out the contribution guidelines. If you have any suggestions how to improve the guidelines, or insights into what works well or can be improved, please let us know. It's good to see you managed to create the issue and merge request.

I used this very first ever non-committer contribution to test out the process of extending your merge request. I found out how to get the merge request into my local Git, and add commits to it. It turns out this leads to a new branch 'merge-requets/28', as it extends merge request !28 that you created. I then added a few commits, as part of reviewing your merge request. These don't appear in merge request !28 as that is from your branch in your own fork of the 'escet' repo on the Eclipse Foundation GitLab. Instead I had to create my own merge request !29 instead. I'll close your merge request !28. Please take a look at merge request !29 to see whether you think my changes are OK.

It is a bit confusing that merge request !29 is now based on branch 'merge-request/28' for issue #25. We may have to find a better way for that.

Thank you for contribution!

Dennis

Van: escet-dev <escet-dev-bounces@xxxxxxxxxxx> namens Ferdie Reijnen <ferdie.reijnen@xxxxxxxxx>
Verzonden: vrijdag 9 april 2021 14:50
Aan: escet-dev@xxxxxxxxxxx <escet-dev@xxxxxxxxxxx>
Onderwerp: [escet-dev] Contributing to ESCET
 
Hello everyone,

I contacted Albert to discuss the possibility of contributing some bug fixes to the ESCET project. He suggested to try to submit a contribution following the developer guidelines. I tried that with a small bug fix for a cif2cif transformation. There should be a merge request for that submission now.

If I did anything wrong or my submission is incomplete please let me know.

Kind regards,
Ferdie
_______________________________________________
escet-dev mailing list
escet-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/escet-dev

Back to the top