| Re: [escet-dev] Contributing to ESCET |
|
Hi Ferdie,
Thanks for trying out the contribution guidelines. If you have any suggestions how to improve the guidelines, or insights into what works well or can be improved, please let us know. It's good to see you managed to create the issue and merge request.
I used this very first ever non-committer contribution to test out the process of extending your merge request. I found out how to get the merge request into my local Git, and add commits to it. It turns out this leads to a new branch 'merge-requets/28', as
it extends merge request !28 that you created. I then added a few commits, as part of reviewing your merge request. These don't appear in merge request !28 as that is from your branch in your own fork of the 'escet' repo on the Eclipse Foundation GitLab. Instead
I had to create my own merge request !29 instead. I'll close your merge request !28. Please take a look at merge request !29 to see whether you think my changes are OK.
It is a bit confusing that merge request !29 is now based on branch 'merge-request/28' for issue #25. We may have to find a better way for that.
Thank you for contribution!
Dennis
Van: escet-dev <escet-dev-bounces@xxxxxxxxxxx> namens Ferdie Reijnen <ferdie.reijnen@xxxxxxxxx>
Verzonden: vrijdag 9 april 2021 14:50 Aan: escet-dev@xxxxxxxxxxx <escet-dev@xxxxxxxxxxx> Onderwerp: [escet-dev] Contributing to ESCET Hello everyone,
I contacted Albert to discuss the possibility of contributing some bug fixes to the ESCET project. He suggested to try to submit a contribution following the developer guidelines. I tried that with a small bug fix for a cif2cif transformation. There should
be a merge request for that submission now.
If I did anything wrong or my submission is incomplete please let me know.
Kind regards,
Ferdie
|