Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [escet-dev] GitLab
  • From: "Hofkamp, A.T." <A.T.Hofkamp@xxxxxx>
  • Date: Thu, 22 Oct 2020 14:13:36 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=tue.nl; dmarc=pass action=none header.from=tue.nl; dkim=pass header.d=tue.nl; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfQjqw3q6tHQcQyfcH8ajvIFEFLSysXzEy+hLcpC/wY=; b=XIK8VoHaLigvyXdph+tVrHUUZELJRSklGoQOYSRACCXopPeyLbTMjCT0Qmzkgzn9x+9+UqTjWU6kHYGHVJd0s9ZF2zvL+vsYC3g7b0Q3ZUW2pv9laubjVyClCEfzGexXYBRKXMAeDQzSeuYTr+jQEK1tDwQzncByMszKbRwLXY0z3TVwxUrFj9jt1iBiXdRa2UkMsm+nUD8tQGIMZfHICmFdg9y6s70QtIy7bBPx/XiWynri3Af3BqW9+urn3gCSChIQmoJaSKLZ8z1Uau9j6pFHKm9/Y9S2qphPcYx0R8IQSMd4LrwhPS9tOptkp/FGDGIvSwMe1y+DrE9yv2oOHA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYw5q0VbQAVCUu83VdSx/E30HC1pI4rOAruCgUCX60Xd5Z/okByIHq05eDVcZQ87AZlUvJSGNS6uUGGOIIZuz/AO0H3O0za3/aQMlbW34gBMxkonD3+nV1i/EyXoys03joqC1BZlydwtaj34xekCpKMP/UiPywQdF0fvFt5i4gf70xTk+UH3zAtpCelZCfNyYNH6x6Hoq+YKjgeEjPXvX5FFcTed6isjnp6qH7zuvdu7Z81bbNIzbuGYABw1pU4xSjSUMYSihaLgybkX1tApeGI5JA436pbe/SMxjUE20dAcmVVdgn8iCZGKhx4Av3d+aXY/izZzSBw9U9psQE9aqg==
  • Delivered-to: escet-dev@xxxxxxxxxxx
  • List-archive: <https://dev.eclipse.org/mailman/private/escet-dev>
  • List-help: <mailto:escet-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://dev.eclipse.org/mailman/listinfo/escet-dev>, <mailto:escet-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://dev.eclipse.org/mailman/options/escet-dev>, <mailto:escet-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHWpgT6jU6rPm4x7ke4VpYc/JI6ramjqGiL
  • Thread-topic: GitLab

> I suggest the following for milestones:

Seems fine.

Epics are indeed topic oriented as far as I know. Mostly anything bigger than a few issues, where you need an overview ticket about purpose, plans, and progress. Never worked with proper Epics though, until now I just used a ticket labeled "[epic] <topic>".

> I suggest the following for issues:

Not many surprises, 2 points:
  •  "... it will create a branch named '2-test'."   The numeric prefix breaks auto-completion at the command-line, since at the same point you can also use a commit hash, and there are a zillion commits that start with a 2. If you type "2-", autocompletion works, but we'll soon have more than 10 or 100 issues. As such, I'd prefer the issue number at the end, don't know if that's possible.
  • Gitflow will likely do all we want, the one problem I have with it is that it breaks standard git semantics of "master". For no good reason, they renamed "master" to "develop", and renamed "releases" to "master" to confuse everybody. Why?


From: escet-dev-bounces@xxxxxxxxxxx <escet-dev-bounces@xxxxxxxxxxx> on behalf of Dennis Hendriks <dh_tue@xxxxxxxxxxx>
Sent: Monday, October 19, 2020 13:02
To: escet developer discussions <escet-dev@xxxxxxxxxxx>
Subject: [escet-dev] GitLab
 
Hi all,

In another discussion, Albert mentioned:

> [...] should we discuss gitlab configuration?
> Issue tags and milestones at least I think, and probably branch usage/names/conventions?
> [...]
In general, I think less is more here.

I suggest the following for milestones:
  • Create a milestone for every release. I created one for Release 0.1.
  • Associate every issue with the release milestone where we fix/address it. This way, we have an overview for the release log for a release. Also, we see what work is still planned for a release.
We have both epics and milestones. Both seem to group issues. Epics seem to be meant to group by functionality while milestones seem more focussed on what you address/finish/release together. You could thus have funcionality in an epic that you release partly as part of one milestone and the rest as part of a next milestone. Maybe if we later have releases with multiple topics (groups of functionality) epics may become handy as well.

I suggest the following for issues:
  • Create an issue for everything that we work on.
  • Keep issues relatively small. This keeps merging easier as we will merge often. Also, it makes reviewing easier, as it will not be too much code.
  • Always work in a branch for the issue.
  • Let GitLab create the branch for the issue. For an issue with number #2 named 'Test', it will create a branch named '2-test'. So that includes the issue number.
  • Adopt GitFlow, see https://datasift.github.io/gitflow/IntroducingGitFlow.html
For commits:
  • The first line must be a short single line summary of max 72 characters I think, as is the Git standard.
  • Prefix the first line with the issue number, e.g. '#1 commit summary', to link the commit to the issue.
  • Adhere to Eclipse requirements, see https://www.eclipse.org/projects/handbook/#resources-commit
These are my first thoughts. Let me know what you think about them and whether you have other ideas.

Dennis


Back to the top