[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [es-dev] Redundant getCallerName and getCallerGroups in OpenIdContext?
|
They return the callerName and Groups for the OpenId since they are located in the OpenIdContext class. Having it not in OpenIdContext means that developers also need the SecurityContext to retrieve all the info, even in the case when they just want to use OpenIdConnect.
But we never had any discussion in this group about what OpenId integration should look like. And thus I stand by my statement I made before, Openid Connect should not have been part of Jakarta EE 10 release as there was no proper discussion and we will release something that is not validated by a wider group of people.
Rudy.
Hi,
In the OpenIdContext there are the two following methods:
/**
* @return the caller name of the validated caller
*/
String getCallerName();
/**
* @return the groups associated with the caller
*/
Set<String> getCallerGroups();
These methods are somewhat redundant, as the SecurityContext is the central place for this. They are also not giving back the actual callerName or groups when, for instance, additional identity stores are used.
As it stands now, they only return what the OpenID Provider returned. Whas that the intention of these methods? If so, we probably should clarify their limited usage. If not, we may better remove them.
Thoughts?
Kind regards,
Arjan
es-dev mailing list
es-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/es-dev
