[es-dev] Redundant getCallerName and getCallerGroups in OpenIdContext?

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi,

In the OpenIdContext there are the two following methods:

  /**
     * @return the caller name of the validated caller
     */
    String getCallerName();

    /**
     * @return the groups associated with the caller
     */
    Set<String> getCallerGroups();

These methods are somewhat redundant, as the SecurityContext is the central place for this. They are also not giving back the actual callerName or groups when, for instance, additional identity stores are used.

As it stands now, they only return what the OpenID Provider returned. Whas that the intention of these methods? If so, we probably should clarify their limited usage. If not, we may better remove them.

Thoughts?

Kind regards,

Arjan